Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Fixed condition for SetIsCreatedFromHashChange call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
diff --git a/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm b/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
index 83d31f8a569ad35efc4cb207931d986cb36ab001..1e05c36cf85b77a0aafd2077a7ef8254a995e57c 100644
--- a/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
+++ b/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
@@ -69,8 +69,9 @@ TEST_F(CRWWKNavigationStatesTest, LastAddedNavigation) {
// navigation_3 is added later and hence the latest.
std::unique_ptr<web::NavigationContextImpl> context =
- NavigationContextImpl::CreateNavigationContext(nullptr /*web_state*/,
- GURL(kTestUrl1));
+ NavigationContextImpl::CreateNavigationContext(
+ nullptr /*web_state*/, GURL(kTestUrl1),
+ ui::PageTransition::PAGE_TRANSITION_SERVER_REDIRECT);
[states_ setContext:std::move(context) forNavigation:navigation3_];
EXPECT_EQ(navigation3_, [states_ lastAddedNavigation]);
EXPECT_EQ(WKNavigationState::NONE, [states_ lastAddedNavigationState]);
@@ -84,8 +85,9 @@ TEST_F(CRWWKNavigationStatesTest, Context) {
// Add first context.
std::unique_ptr<web::NavigationContextImpl> context1 =
- NavigationContextImpl::CreateNavigationContext(nullptr /*web_state*/,
- GURL(kTestUrl1));
+ NavigationContextImpl::CreateNavigationContext(
+ nullptr /*web_state*/, GURL(kTestUrl1),
+ ui::PageTransition::PAGE_TRANSITION_RELOAD);
context1->SetIsSameDocument(true);
[states_ setContext:std::move(context1) forNavigation:navigation1_];
EXPECT_FALSE([states_ contextForNavigation:navigation2_]);
@@ -98,8 +100,9 @@ TEST_F(CRWWKNavigationStatesTest, Context) {
// Replace existing context.
std::unique_ptr<web::NavigationContextImpl> context2 =
- NavigationContextImpl::CreateNavigationContext(nullptr /*web_state*/,
- GURL(kTestUrl2));
+ NavigationContextImpl::CreateNavigationContext(
+ nullptr /*web_state*/, GURL(kTestUrl2),
+ ui::PageTransition::PAGE_TRANSITION_GENERATED);
context2->SetIsErrorPage(true);
[states_ setContext:std::move(context2) forNavigation:navigation1_];
EXPECT_FALSE([states_ contextForNavigation:navigation2_]);

Powered by Google App Engine
This is Rietveld 408576698