Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2896533003: [css-grid] Properly reset auto repeat style attributes (Closed)

Created:
3 years, 7 months ago by svillar
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[css-grid] Properly reset auto repeat style attributes All the auto repeat attributes stored in ComputedStyle were not properly initialized/set up whenever initial or inherit were used in grid-template-{columns|rows}. This means that any previous value would be incorrectly used by the grid layout logic like for example to compute the number of auto repeat tracks. This was causing crashes as we were trying to access invalid indexes in the Vectors storing the style information for tracks. BUG=722054 Review-Url: https://codereview.chromium.org/2885003002 Cr-Original-Commit-Position: refs/heads/master@{#472396} Review-Url: https://codereview.chromium.org/2896533003 . Cr-Commit-Position: refs/branch-heads/3071@{#627} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e50c18655716345368c5d6ce1c3c954546ac585b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
svillar
3 years, 7 months ago (2017-05-19 08:38:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e50c18655716345368c5d6ce1c3c954546ac585b.

Powered by Google App Engine
This is Rietveld 408576698