Chromium Code Reviews
Description[css-grid] Properly reset auto repeat style attributes
All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.
This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.
BUG=722054
Review-Url: https://codereview.chromium.org/2885003002
Cr-Original-Commit-Position: refs/heads/master@{#472396}
Review-Url: https://codereview.chromium.org/2896533003 .
Cr-Commit-Position: refs/branch-heads/3071@{#627}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/e50c18655716345368c5d6ce1c3c954546ac585b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||