[css-grid] Properly reset auto repeat style attributes

[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054
Review-Url: https://codereview.chromium.org/2885003002
Cr-Commit-Position: refs/heads/master@{#472396}
Committed: https://chromium.googlesource.com/chromium/src/+/b3a11019e6709be450e8dc92130e53920c0e5717

[svillar, 2017-05-16 14:30:46]

svillar@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, rego@igalia.com

[svillar, 2017-05-16 14:30:47]

Sending out for review

[Manuel Rego, 2017-05-16 15:32:46]

I'm wondering if this is enough or not.
What happens if you do "grid-template-columns: inherit;"
I see that's currently crashing (without your patch).

BTW, a typo in the description "atributed".

[svillar, 2017-05-16 15:35:57]

On 2017/05/16 15:32:46, Manuel Rego wrote:
> I'm wondering if this is enough or not.
> What happens if you do "grid-template-columns: inherit;"
> I see that's currently crashing (without your patch).

I'm lost, have you seen the test cases I've attached?

> BTW, a typo in the description "atributed".

ACK

[svillar, 2017-05-16 15:36:10]

Description was changed from

==========
[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributed stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054
==========

to

==========
[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054
==========

[Manuel Rego, 2017-05-16 15:44:05]

On 2017/05/16 15:35:57, svillar wrote:
> On 2017/05/16 15:32:46, Manuel Rego wrote:
> > I'm wondering if this is enough or not.
> > What happens if you do "grid-template-columns: inherit;"
> > I see that's currently crashing (without your patch).
> 
> I'm lost, have you seen the test cases I've attached?

Oops sorry, I got confused reading the macro:
"apply_grid_template".
Dunno why I thought it was about "grid-template" property,
then I see the test of the bug with the "grid: initial"
and didn't check the values in your tests.

Sorry for the confusion. LGTM. :-)

[svillar, 2017-05-17 07:46:44]

The CQ bit was checked by svillar@igalia.com

[commit-bot: I haz the power, 2017-05-17 07:47:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:30:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495007204589290, "parent_rev":
"d38becdb2a4dda654d795cb841111778673c0b1d", "commit_rev":
"b3a11019e6709be450e8dc92130e53920c0e5717"}

[commit-bot: I haz the power, 2017-05-17 09:30:52]

Description was changed from

==========
[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054
==========

to

==========
[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054

Review-Url: https://codereview.chromium.org/2885003002
Cr-Commit-Position: refs/heads/master@{#472396}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3a11019e6709be450e8dc92130e...
==========

[commit-bot: I haz the power, 2017-05-17 09:30:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3a11019e6709be450e8dc92130e...