Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2896483002: [DMC #6.9] Simplify DMC::InvalidateRectsForAllMarkers() (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify DMC::InvalidateRectsForAllMarkers() Implement DocumentMarkerController::InvalidateRectsForAllMarkers() on top of InvalidateRectsForMarkersInNode(). This makes the code easier to understand and simplifies maintenance. BUG=707867 Review-Url: https://codereview.chromium.org/2896483002 Cr-Commit-Position: refs/heads/master@{#473114} Committed: https://chromium.googlesource.com/chromium/src/+/34da61835c4da3f85eb33448a87a5dc530d6dc61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
rlanday
3 years, 7 months ago (2017-05-18 20:26:25 UTC) #3
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-18 20:39:00 UTC) #5
yosin_UTC9
lgtm Good catch! (^_^)b
3 years, 7 months ago (2017-05-19 05:53:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896483002/1
3 years, 7 months ago (2017-05-19 05:54:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 07:04:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34da61835c4da3f85eb33448a87a...

Powered by Google App Engine
This is Rietveld 408576698