Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/elements.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index 69fae3817eb167c8e5f225969367cfbfe1e37d20..543a705daea6628a82e7f237fd055d092efeae8c 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -1240,7 +1240,7 @@ class KernelVisitor extends Object
@override
ir.InvocationExpression visitBoolFromEnvironmentConstructorInvoke(
NewExpression node, BoolFromEnvironmentConstantExpression constant, _) {
- return buildConstructorInvoke(node, isConst: true);
+ return associateNode(buildConstructorInvoke(node, isConst: true), node);
}
ir.TypeLiteral buildTypeLiteral(TypeConstantExpression constant) {
@@ -1737,7 +1737,7 @@ class KernelVisitor extends Object
@override
ir.InvocationExpression visitIntFromEnvironmentConstructorInvoke(
NewExpression node, IntFromEnvironmentConstantExpression constant, _) {
- return buildConstructorInvoke(node, isConst: true);
+ return associateNode(buildConstructorInvoke(node, isConst: true), node);
}
ir.IsExpression buildIs(Node expression, ResolutionDartType type) {
@@ -2352,7 +2352,7 @@ class KernelVisitor extends Object
@override
ir.InvocationExpression visitStringFromEnvironmentConstructorInvoke(
NewExpression node, StringFromEnvironmentConstantExpression constant, _) {
- return buildConstructorInvoke(node, isConst: true);
+ return associateNode(buildConstructorInvoke(node, isConst: true), node);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/kernel/elements.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698