Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: pkg/compiler/lib/src/kernel/elements.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/element_map_impl.dart ('k') | pkg/compiler/lib/src/kernel/kernel_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/elements.dart
diff --git a/pkg/compiler/lib/src/kernel/elements.dart b/pkg/compiler/lib/src/kernel/elements.dart
index 305c41a10f1dc1655c7112e4135fc450f39aafc1..8989f5ee92f218c3a038603cc84b43feb4749398 100644
--- a/pkg/compiler/lib/src/kernel/elements.dart
+++ b/pkg/compiler/lib/src/kernel/elements.dart
@@ -120,6 +120,9 @@ abstract class KConstructor extends KFunction implements ConstructorEntity {
@override
bool get isTopLevel => false;
+ @override
+ bool get isFromEnvironmentConstructor => false;
+
String get _kind => 'constructor';
}
@@ -137,8 +140,12 @@ class KGenerativeConstructor extends KConstructor {
}
class KFactoryConstructor extends KConstructor {
+ @override
+ final bool isFromEnvironmentConstructor;
+
KFactoryConstructor(int memberIndex, KClass enclosingClass, Name name,
- ParameterStructure parameterStructure, {bool isExternal, bool isConst})
+ ParameterStructure parameterStructure,
+ {bool isExternal, bool isConst, this.isFromEnvironmentConstructor})
: super(memberIndex, enclosingClass, name, parameterStructure,
isExternal: isExternal, isConst: isConst);
« no previous file with comments | « pkg/compiler/lib/src/kernel/element_map_impl.dart ('k') | pkg/compiler/lib/src/kernel/kernel_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698