Remove factory body in *.fromEnvironment, and implement this same behavior

pkg/compiler/lib/src/kernel/kernel_visitor.dart

 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE.md file.
 
 import 'package:kernel/ast.dart' as ir;
 import 'package:kernel/frontend/accessors.dart'
     show
         Accessor,
         IndexAccessor,
         NullAwarePropertyAccessor,
@@ skipping 1222 matching lines @@
       if (type.isGeneric) {
         invoke.arguments.types.addAll(kernel.typesToIr(type.typeArguments));
       }
     }
     return invoke;
   }
 
   @override
   ir.InvocationExpression visitBoolFromEnvironmentConstructorInvoke(
       NewExpression node, BoolFromEnvironmentConstantExpression constant, _) {
-    return buildConstructorInvoke(node, isConst: true);
+    return associateNode(buildConstructorInvoke(node, isConst: true), node);
   }
 
   ir.TypeLiteral buildTypeLiteral(TypeConstantExpression constant) {
     return new ir.TypeLiteral(kernel.typeLiteralToIr(constant));
   }
 
   @override
   ir.Expression visitClassTypeLiteralGet(
       Send node, ConstantExpression constant, _) {
     var loadedCheckFunc =
@@ skipping 476 matching lines @@
 
   @override
   IrFunction visitInstanceSetterDeclaration(FunctionExpression node,
       MethodElement setter, NodeList parameters, Node body, _) {
     return buildIrFunction(ir.ProcedureKind.Setter, setter, body);
   }
 
   @override
   ir.InvocationExpression visitIntFromEnvironmentConstructorInvoke(
       NewExpression node, IntFromEnvironmentConstantExpression constant, _) {
-    return buildConstructorInvoke(node, isConst: true);
+    return associateNode(buildConstructorInvoke(node, isConst: true), node);
   }
 
   ir.IsExpression buildIs(Node expression, ResolutionDartType type) {
     return new ir.IsExpression(
         visitForValue(expression), kernel.typeToIr(type));
   }
 
   @override
   ir.IsExpression visitIs(
       Send node, Node expression, ResolutionDartType type, _) {
@@ skipping 594 matching lines @@
   @override
   ir.Expression handleStaticSetterSet(
       SendSet node, FunctionElement setter, Node rhs, _) {
     return buildStaticAccessor(null, setter)
         .buildAssignment(visitForValue(rhs), voidContext: isVoidContext);
   }
 
   @override
   ir.InvocationExpression visitStringFromEnvironmentConstructorInvoke(
       NewExpression node, StringFromEnvironmentConstantExpression constant, _) {
-    return buildConstructorInvoke(node, isConst: true);
+    return associateNode(buildConstructorInvoke(node, isConst: true), node);
   }
 
   @override
   ir.SuperMethodInvocation visitSuperBinary(Send node, FunctionElement function,
       BinaryOperator operator, Node argument, _) {
     transformerFlags |= TransformerFlag.superCalls;
     return new ir.SuperMethodInvocation(
         kernel.irName(operator.selectorName, currentElement),
         new ir.Arguments(<ir.Expression>[visitForValue(argument)]),
         kernel.functionToIr(function));
@@ skipping 601 matching lines @@
       : this(null, true, node, initializers);
 
   accept(ir.Visitor v) => throw "unsupported";
 
   visitChildren(ir.Visitor v) => throw "unsupported";
 
   String toString() {
     return "IrFunction($kind, $isConstructor, $node, $initializers)";
   }
 }