Make profile error dialog checkbox opt-in and improve feedback description

Make profile error dialog checkbox opt-in and improve feedback description

1) Change the profile error dialog checkbox to report a feedback when the
   dialog is dismissed to be opt-in instead of opt-out.
2) Change the scary message "DO NOT CHANGE BELOW THIS LINE" to "Please do
   not change below this line".
3) Only show the above message if we actually have some diagnostics data
   to add to the report.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=708505#c4

BUG=708505
TEST=On Chrome OS, run 'stop ui', trigger a profile error by
'echo "<some long random text>" > /home/chronos/Default/History'. Run 'start ui'.
Make sure the checkbox is opt in in the error dialog, check the box, and click OK,
the feedback is pre-populated with a message like the one in the screenshots.

Review-Url: https://codereview.chromium.org/2896133002
Cr-Commit-Position: refs/heads/master@{#473813}
Committed: https://chromium.googlesource.com/chromium/src/+/e4d990302ab30a05aada8e4928e3ec19a02222a7

[afakhry, 2017-05-22 23:52:05]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:52:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-05-22 23:53:29]

afakhry@chromium.org changed reviewers:
+ pkasting@chromium.org

[afakhry, 2017-05-22 23:53:30]

pkasting, please take a look. Thank you!

[commit-bot: I haz the power, 2017-05-23 00:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:51:23]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-05-23 01:14:28]

LGTM

https://codereview.chromium.org/2896133002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2896133002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9138: <message
name="IDS_PROFILE_ERROR_FEEDBACK_DIAGNOSTICS_LINE" desc="The prepopulated text
filled in the feedback report reporting a profile error disgnostics information.
The triple single quotes are needed to preserve the line break.">
Nit: "error diagnostics" -> "error, above any diagnostics"

[afakhry, 2017-05-23 04:25:07]

https://codereview.chromium.org/2896133002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2896133002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9138: <message
name="IDS_PROFILE_ERROR_FEEDBACK_DIAGNOSTICS_LINE" desc="The prepopulated text
filled in the feedback report reporting a profile error disgnostics information.
The triple single quotes are needed to preserve the line break.">
On 2017/05/23 01:14:27, Peter Kasting wrote:
> Nit: "error diagnostics" -> "error, above any diagnostics"

Done.

[afakhry, 2017-05-23 04:25:12]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-05-23 04:25:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2896133002/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2017-05-23 04:25:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 05:09:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495513512631020,
"parent_rev": "a130e7da44391ae1f901a65491d05d343216c22a", "commit_rev":
"e4d990302ab30a05aada8e4928e3ec19a02222a7"}

[commit-bot: I haz the power, 2017-05-23 05:09:34]

Description was changed from

==========
Make profile error dialog checkbox opt-in and improve feedback description

1) Change the profile error dialog checkbox to report a feedback when the
   dialog is dismissed to be opt-in instead of opt-out.
2) Change the scary message "DO NOT CHANGE BELOW THIS LINE" to "Please do
   not change below this line".
3) Only show the above message if we actually have some diagnostics data
   to add to the report.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=708505#c4

BUG=708505
TEST=On Chrome OS, run 'stop ui', trigger a profile error by
'echo "<some long random text>" > /home/chronos/Default/History'. Run 'start
ui'.
Make sure the checkbox is opt in in the error dialog, check the box, and click
OK,
the feedback is pre-populated with a message like the one in the screenshots.
==========

to

==========
Make profile error dialog checkbox opt-in and improve feedback description

1) Change the profile error dialog checkbox to report a feedback when the
   dialog is dismissed to be opt-in instead of opt-out.
2) Change the scary message "DO NOT CHANGE BELOW THIS LINE" to "Please do
   not change below this line".
3) Only show the above message if we actually have some diagnostics data
   to add to the report.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=708505#c4

BUG=708505
TEST=On Chrome OS, run 'stop ui', trigger a profile error by
'echo "<some long random text>" > /home/chronos/Default/History'. Run 'start
ui'.
Make sure the checkbox is opt in in the error dialog, check the box, and click
OK,
the feedback is pre-populated with a message like the one in the screenshots.

Review-Url: https://codereview.chromium.org/2896133002
Cr-Commit-Position: refs/heads/master@{#473813}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4d990302ab30a05aada8e4928e3...
==========

[commit-bot: I haz the power, 2017-05-23 05:09:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4d990302ab30a05aada8e4928e3...