Don't send saved password domain

Don't send saved password domain for a password reuse event for now.


BUG=724692
Review-Url: https://codereview.chromium.org/2896053002
Cr-Commit-Position: refs/heads/master@{#473711}
Committed: https://chromium.googlesource.com/chromium/src/+/cf41c1ce2ae577daf642d07417fd6afd25c30a55

[Jialiu Lin, 2017-05-22 18:22:41]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:23:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-05-22 18:25:10]

Description was changed from

==========
Don't send saved password domain

BUG=724692
==========

to

==========
Don't send saved password domain for now.


BUG=724692
==========

[Jialiu Lin, 2017-05-22 18:25:10]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2017-05-22 18:25:33]

Description was changed from

==========
Don't send saved password domain for now.


BUG=724692
==========

to

==========
Don't send saved password domain for a password reuse event for now.


BUG=724692
==========

[Jialiu Lin, 2017-05-22 18:28:30]

Patchset #2 (id:20001) has been deleted

[Jialiu Lin, 2017-05-22 18:28:38]

Patchset #2 (id:40001) has been deleted

[Nathan Parker, 2017-05-22 19:50:31]

Thanks.  One addition.

https://codereview.chromium.org/2896053002/diff/60001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2896053002/diff/60001/components/safe_browsin...
components/safe_browsing/csd.proto:216: optional int32 frame_id = 2;
Also add this missing field:

// Whether the reused password is used for Chrome signin.
optional bool is_chrome_signin_password = 3;

[Jialiu Lin, 2017-05-22 20:02:41]

https://codereview.chromium.org/2896053002/diff/60001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2896053002/diff/60001/components/safe_browsin...
components/safe_browsing/csd.proto:216: optional int32 frame_id = 2;
On 2017/05/22 19:50:31, Nathan Parker wrote:
> Also add this missing field:
> 
> // Whether the reused password is used for Chrome signin.
> optional bool is_chrome_signin_password = 3;

Done.

[Nathan Parker, 2017-05-22 20:40:43]

lgtm

[Jialiu Lin, 2017-05-22 20:43:23]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:43:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:45:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495485803853460,
"parent_rev": "7edef8fcbb3ed857191ff14296527fe918ade889", "commit_rev":
"cf41c1ce2ae577daf642d07417fd6afd25c30a55"}

[commit-bot: I haz the power, 2017-05-22 21:45:23]

Description was changed from

==========
Don't send saved password domain for a password reuse event for now.


BUG=724692
==========

to

==========
Don't send saved password domain for a password reuse event for now.


BUG=724692

Review-Url: https://codereview.chromium.org/2896053002
Cr-Commit-Position: refs/heads/master@{#473711}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf41c1ce2ae577daf642d07417fd...
==========

[commit-bot: I haz the power, 2017-05-22 21:45:24]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cf41c1ce2ae577daf642d07417fd...