Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: components/safe_browsing/password_protection/password_protection_service_unittest.cc

Issue 2896053002: Don't send saved password domain (Closed)
Patch Set: add is_chrome_signin_password Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/password_protection/password_protection_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/password_protection/password_protection_service_unittest.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service_unittest.cc b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
index f86c41f22f059bd28b533798d6091501fe50c1d7..deb07cc2db96373e9d44556878e8d2be488f84e6 100644
--- a/components/safe_browsing/password_protection/password_protection_service_unittest.cc
+++ b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
@@ -630,11 +630,8 @@ TEST_F(PasswordProtectionServiceTest,
actual_request->trigger_type());
EXPECT_EQ(1, actual_request->frames_size());
EXPECT_EQ(kTargetUrl, actual_request->frames(0).url());
- ASSERT_TRUE(actual_request->has_password_reuse_event());
- ASSERT_EQ(1, actual_request->password_reuse_event()
- .password_reused_original_origins_size());
- EXPECT_EQ(kSavedDomain, actual_request->password_reuse_event()
- .password_reused_original_origins(0));
+ // TODO(jialiul): Update this test when we're ready to fill more fields.
+ ASSERT_FALSE(actual_request->has_password_reuse_event());
}
} // namespace safe_browsing
« no previous file with comments | « components/safe_browsing/password_protection/password_protection_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698