Misc cleanup in net/spdy/core.

Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments,
* use SpdyMakeUnique instead of base::MakeUnique.

Most of these changes is either to what the internal code is like
already, or what the currently under review 156860094 is going to
change it.

BUG=488484
Review-Url: https://codereview.chromium.org/2895993003
Cr-Commit-Position: refs/heads/master@{#474307}
Committed: https://chromium.googlesource.com/chromium/src/+/dd4c4686aac1bfd2230fdabb624da2892eb5e145

[Bence, 2017-05-22 19:15:49]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:16:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:54:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bence, 2017-05-23 14:32:12]

Description was changed from

==========
CL description to filled in later.
==========

to

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

BUG=488484
==========

[Bence, 2017-05-23 14:55:01]

Description was changed from

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

BUG=488484
==========

to

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

Code is changed either into what it is like internally already, or what the
currently under review 156860094 is going to change internal code.

BUG=488484
==========

[Bence, 2017-05-23 14:55:21]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 14:56:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-23 15:22:47]

Description was changed from

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

Code is changed either into what it is like internally already, or what the
currently under review 156860094 is going to change internal code.

BUG=488484
==========

to

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

Code is changed either into what it is like internally already,
or what the currently under review 156860094 is going to change
internal code to.

BUG=488484
==========

[Bence, 2017-05-23 15:24:54]

Description was changed from

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments.

Code is changed either into what it is like internally already,
or what the currently under review 156860094 is going to change
internal code to.

BUG=488484
==========

to

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments,
* use SpdyMakeUnique instead of base::MakeUnique.

Most of these changes is either to what the internal code is like
already, or what the currently under review 156860094 is going to
change it.

BUG=488484
==========

[Bence, 2017-05-23 15:26:59]

bnc@chromium.org changed reviewers:
+ birenroy@chromium.org

[Bence, 2017-05-23 15:26:59]

Biren: PTAL.  Thanks.

[commit-bot: I haz the power, 2017-05-23 16:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:54:49]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-05-24 11:55:53]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 11:56:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 13:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 13:21:56]

Dry run: This issue passed the CQ dry run.

[Biren Roy, 2017-05-24 15:25:10]

lgtm

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_fram...
File net/spdy/core/spdy_framer.cc (right):

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_fram...
net/spdy/core/spdy_framer.cc:1051: } break;
This line looks weird, but I see it's the same in the internal version.

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_test...
File net/spdy/core/spdy_test_utils.cc (right):

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_test...
net/spdy/core/spdy_test_utils.cc:43: for (const unsigned char* p = row; p < row
+ 4; ++p) {
These two diffs, in conjunction, make me sad. :(

[Bence, 2017-05-24 15:38:47]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2017-05-24 15:38:48]

xunjieli: please rubber stamp.
Biren: thank you for reviewing.

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_fram...
File net/spdy/core/spdy_framer.cc (right):

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_fram...
net/spdy/core/spdy_framer.cc:1051: } break;
On 2017/05/24 15:25:09, Biren Roy wrote:
> This line looks weird, but I see it's the same in the internal version.

Yeah, I agree.  Maybe if I move all local variable declaration outside of the
switch statement, then we can get rid of the per-case curly brackets.

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_test...
File net/spdy/core/spdy_test_utils.cc (right):

https://codereview.chromium.org/2895993003/diff/80001/net/spdy/core/spdy_test...
net/spdy/core/spdy_test_utils.cc:43: for (const unsigned char* p = row; p < row
+ 4; ++p) {
On 2017/05/24 15:25:09, Biren Roy wrote:
> These two diffs, in conjunction, make me sad. :(

You are not the only one.  I tried to change it, but strangely enough, the
internal git clang-format really insist on this.  On the other hand, Chromium's
git cl format accepts either form for both lines.

[xunjieli, 2017-05-24 15:49:02]

lgtm

[Bence, 2017-05-24 15:53:02]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:53:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 15:58:46]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495641182317090,
"parent_rev": "ddffa7d52640d5a9d1ac7a6d6180dabdab75ff05", "commit_rev":
"dd4c4686aac1bfd2230fdabb624da2892eb5e145"}

[commit-bot: I haz the power, 2017-05-24 15:58:56]

Description was changed from

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments,
* use SpdyMakeUnique instead of base::MakeUnique.

Most of these changes is either to what the internal code is like
already, or what the currently under review 156860094 is going to
change it.

BUG=488484
==========

to

==========
Misc cleanup in net/spdy/core.

In order to remove some of the differences from the internal codebase:
* reorder of declarations/definitions;
* remove unnecessary casts,
* change C-style casts to static_casts,
* remove unnecessary includes,
* remove unnecessary TestWithParam base class,
* add std:: namespace qualifier,
* change virtual to override,
* clang-format,
* fix and reflow comments,
* use SpdyMakeUnique instead of base::MakeUnique.

Most of these changes is either to what the internal code is like
already, or what the currently under review 156860094 is going to
change it.

BUG=488484

Review-Url: https://codereview.chromium.org/2895993003
Cr-Commit-Position: refs/heads/master@{#474307}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd4c4686aac1bfd2230fdabb624d...
==========

[commit-bot: I haz the power, 2017-05-24 15:58:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dd4c4686aac1bfd2230fdabb624d...