Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: net/spdy/core/array_output_buffer_test.cc

Issue 2895993003: Misc cleanup in net/spdy/core. (Closed)
Patch Set: Rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/core/array_output_buffer_test.cc
diff --git a/net/spdy/core/array_output_buffer_test.cc b/net/spdy/core/array_output_buffer_test.cc
index 75629bac184ddbce47ee7964742903395a6053be..cd10011b9cc443eeb18151350e90603f5a7627dd 100644
--- a/net/spdy/core/array_output_buffer_test.cc
+++ b/net/spdy/core/array_output_buffer_test.cc
@@ -14,7 +14,7 @@ TEST(ArrayOutputBufferTest, InitializedFromArray) {
char array[100];
ArrayOutputBuffer buffer(array, sizeof(array));
EXPECT_EQ(sizeof(array), buffer.BytesFree());
- EXPECT_EQ((uint64_t)0, buffer.Size());
+ EXPECT_EQ(0u, buffer.Size());
EXPECT_EQ(array, buffer.Begin());
}
@@ -35,14 +35,14 @@ TEST(ArrayOutputBufferTest, WriteAndReset) {
buffer.AdvanceWritePtr(written);
// The buffer should be partially used.
- EXPECT_EQ((uint64_t)size - written, buffer.BytesFree());
- EXPECT_EQ((uint64_t)written, buffer.Size());
+ EXPECT_EQ(static_cast<uint64_t>(size) - written, buffer.BytesFree());
+ EXPECT_EQ(static_cast<uint64_t>(written), buffer.Size());
buffer.Reset();
// After a reset, the buffer should regain its full capacity.
EXPECT_EQ(sizeof(array), buffer.BytesFree());
- EXPECT_EQ((uint64_t)0, buffer.Size());
+ EXPECT_EQ(0u, buffer.Size());
}
} // namespace test

Powered by Google App Engine
This is Rietveld 408576698