Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp

Issue 2895933004: Pass the correct BorderWidth value when creating BorderValues (Closed)
Patch Set: add computedstyle unit tes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp b/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
index 3a791da9ae349028266000f605f01038a338b2ca..67bcf5f32063816f9615d2d6c7ae0f14469a4b3c 100644
--- a/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
+++ b/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
@@ -47,6 +47,7 @@ TEST(CollapsedBorderValueTest, SolidNonZeroWidthTransparent) {
auto style = ComputedStyle::Create();
style->SetBorderLeftWidth(5);
style->SetBorderLeftStyle(EBorderStyle::kSolid);
+ EXPECT_EQ(style->BorderLeft().Width(), 5);
CollapsedBorderValue v(style->BorderLeft(), Color(), kBorderPrecedenceCell);
EXPECT_TRUE(v.Exists());
EXPECT_EQ(5u, v.Width());
@@ -65,6 +66,7 @@ TEST(CollapsedBorderValueTest, None) {
auto style = ComputedStyle::Create();
style->SetBorderLeftWidth(5);
style->SetBorderLeftStyle(EBorderStyle::kNone);
+ EXPECT_EQ(style->BorderLeft().Width(), 5);
CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
kBorderPrecedenceCell);
EXPECT_TRUE(v.Exists());
@@ -85,6 +87,7 @@ TEST(CollapsedBorderValueTest, Hidden) {
auto style = ComputedStyle::Create();
style->SetBorderLeftWidth(5);
style->SetBorderLeftStyle(EBorderStyle::kHidden);
+ EXPECT_EQ(style->BorderLeft().Width(), 5);
CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
kBorderPrecedenceCell);
EXPECT_TRUE(v.Exists());
@@ -105,6 +108,7 @@ TEST(CollapsedBorderValueTest, SolidNonZeroWidthNonTransparent) {
auto style = ComputedStyle::Create();
style->SetBorderLeftWidth(5);
style->SetBorderLeftStyle(EBorderStyle::kSolid);
+ EXPECT_EQ(style->BorderLeft().Width(), 5);
CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
kBorderPrecedenceCell);
EXPECT_TRUE(v.Exists());

Powered by Google App Engine
This is Rietveld 408576698