third_party/WebKit/Source/core/layout/CollapsedBorderValue.h - Issue 2895933004: Pass the correct BorderWidth value when creating BorderValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/CollapsedBorderValue.h

Issue 2895933004: Pass the correct BorderWidth value when creating BorderValues (Closed)

Patch Set: add computedstyle unit tes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/CollapsedBorderValue.h

diff --git a/third_party/WebKit/Source/core/layout/CollapsedBorderValue.h b/third_party/WebKit/Source/core/layout/CollapsedBorderValue.h

index e246348549923462011c888ee301a66a24570cb9..4cd2318cfb435519957afc02737e3942887f6e78 100644

--- a/third_party/WebKit/Source/core/layout/CollapsedBorderValue.h

+++ b/third_party/WebKit/Source/core/layout/CollapsedBorderValue.h

@@ -55,7 +55,7 @@ class CollapsedBorderValue {

const Color& color,

EBorderPrecedence precedence)

: color_(color),

- width_(border.Style() > EBorderStyle::kNone ? border.Width() : 0),

+ width_(border.Style() > EBorderStyle::kHidden ? border.Width() : 0),

style_(static_cast<unsigned>(border.Style())),

precedence_(precedence) {

DCHECK(precedence != kBorderPrecedenceOff);