Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp

Issue 2895933004: Pass the correct BorderWidth value when creating BorderValues (Closed)
Patch Set: add computedstyle unit tes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/CollapsedBorderValue.h" 5 #include "core/layout/CollapsedBorderValue.h"
6 6
7 #include "core/style/ComputedStyle.h" 7 #include "core/style/ComputedStyle.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 29 matching lines...) Expand all
40 EXPECT_FALSE(v.IsSameIgnoringColor( 40 EXPECT_FALSE(v.IsSameIgnoringColor(
41 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(), 41 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(),
42 Color(0, 255, 0), kBorderPrecedenceCell))); 42 Color(0, 255, 0), kBorderPrecedenceCell)));
43 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue())); 43 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue()));
44 } 44 }
45 45
46 TEST(CollapsedBorderValueTest, SolidNonZeroWidthTransparent) { 46 TEST(CollapsedBorderValueTest, SolidNonZeroWidthTransparent) {
47 auto style = ComputedStyle::Create(); 47 auto style = ComputedStyle::Create();
48 style->SetBorderLeftWidth(5); 48 style->SetBorderLeftWidth(5);
49 style->SetBorderLeftStyle(EBorderStyle::kSolid); 49 style->SetBorderLeftStyle(EBorderStyle::kSolid);
50 EXPECT_EQ(style->BorderLeft().Width(), 5);
50 CollapsedBorderValue v(style->BorderLeft(), Color(), kBorderPrecedenceCell); 51 CollapsedBorderValue v(style->BorderLeft(), Color(), kBorderPrecedenceCell);
51 EXPECT_TRUE(v.Exists()); 52 EXPECT_TRUE(v.Exists());
52 EXPECT_EQ(5u, v.Width()); 53 EXPECT_EQ(5u, v.Width());
53 EXPECT_TRUE(v.IsTransparent()); 54 EXPECT_TRUE(v.IsTransparent());
54 EXPECT_FALSE(v.IsVisible()); 55 EXPECT_FALSE(v.IsVisible());
55 56
56 EXPECT_TRUE(v.IsSameIgnoringColor(v)); 57 EXPECT_TRUE(v.IsSameIgnoringColor(v));
57 EXPECT_TRUE(v.VisuallyEquals(v)); 58 EXPECT_TRUE(v.VisuallyEquals(v));
58 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue())); 59 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue()));
59 EXPECT_TRUE(v.IsSameIgnoringColor(CollapsedBorderValue( 60 EXPECT_TRUE(v.IsSameIgnoringColor(CollapsedBorderValue(
60 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell))); 61 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell)));
61 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue())); 62 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue()));
62 } 63 }
63 64
64 TEST(CollapsedBorderValueTest, None) { 65 TEST(CollapsedBorderValueTest, None) {
65 auto style = ComputedStyle::Create(); 66 auto style = ComputedStyle::Create();
66 style->SetBorderLeftWidth(5); 67 style->SetBorderLeftWidth(5);
67 style->SetBorderLeftStyle(EBorderStyle::kNone); 68 style->SetBorderLeftStyle(EBorderStyle::kNone);
69 EXPECT_EQ(style->BorderLeft().Width(), 5);
68 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0), 70 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
69 kBorderPrecedenceCell); 71 kBorderPrecedenceCell);
70 EXPECT_TRUE(v.Exists()); 72 EXPECT_TRUE(v.Exists());
71 EXPECT_EQ(0u, v.Width()); 73 EXPECT_EQ(0u, v.Width());
72 EXPECT_FALSE(v.IsTransparent()); 74 EXPECT_FALSE(v.IsTransparent());
73 EXPECT_FALSE(v.IsVisible()); 75 EXPECT_FALSE(v.IsVisible());
74 76
75 EXPECT_TRUE(v.IsSameIgnoringColor(v)); 77 EXPECT_TRUE(v.IsSameIgnoringColor(v));
76 EXPECT_TRUE(v.VisuallyEquals(v)); 78 EXPECT_TRUE(v.VisuallyEquals(v));
77 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue())); 79 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue()));
78 EXPECT_TRUE(v.IsSameIgnoringColor( 80 EXPECT_TRUE(v.IsSameIgnoringColor(
79 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(), 81 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(),
80 Color(0, 255, 0), kBorderPrecedenceCell))); 82 Color(0, 255, 0), kBorderPrecedenceCell)));
81 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue())); 83 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue()));
82 } 84 }
83 85
84 TEST(CollapsedBorderValueTest, Hidden) { 86 TEST(CollapsedBorderValueTest, Hidden) {
85 auto style = ComputedStyle::Create(); 87 auto style = ComputedStyle::Create();
86 style->SetBorderLeftWidth(5); 88 style->SetBorderLeftWidth(5);
87 style->SetBorderLeftStyle(EBorderStyle::kHidden); 89 style->SetBorderLeftStyle(EBorderStyle::kHidden);
90 EXPECT_EQ(style->BorderLeft().Width(), 5);
88 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0), 91 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
89 kBorderPrecedenceCell); 92 kBorderPrecedenceCell);
90 EXPECT_TRUE(v.Exists()); 93 EXPECT_TRUE(v.Exists());
91 EXPECT_EQ(0u, v.Width()); 94 EXPECT_EQ(0u, v.Width());
92 EXPECT_FALSE(v.IsTransparent()); 95 EXPECT_FALSE(v.IsTransparent());
93 EXPECT_FALSE(v.IsVisible()); 96 EXPECT_FALSE(v.IsVisible());
94 97
95 EXPECT_TRUE(v.IsSameIgnoringColor(v)); 98 EXPECT_TRUE(v.IsSameIgnoringColor(v));
96 EXPECT_TRUE(v.VisuallyEquals(v)); 99 EXPECT_TRUE(v.VisuallyEquals(v));
97 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue())); 100 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue()));
98 EXPECT_FALSE(v.IsSameIgnoringColor( 101 EXPECT_FALSE(v.IsSameIgnoringColor(
99 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(), 102 CollapsedBorderValue(ComputedStyle::Create()->BorderLeft(),
100 Color(0, 255, 0), kBorderPrecedenceCell))); 103 Color(0, 255, 0), kBorderPrecedenceCell)));
101 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue())); 104 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue()));
102 } 105 }
103 106
104 TEST(CollapsedBorderValueTest, SolidNonZeroWidthNonTransparent) { 107 TEST(CollapsedBorderValueTest, SolidNonZeroWidthNonTransparent) {
105 auto style = ComputedStyle::Create(); 108 auto style = ComputedStyle::Create();
106 style->SetBorderLeftWidth(5); 109 style->SetBorderLeftWidth(5);
107 style->SetBorderLeftStyle(EBorderStyle::kSolid); 110 style->SetBorderLeftStyle(EBorderStyle::kSolid);
111 EXPECT_EQ(style->BorderLeft().Width(), 5);
108 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0), 112 CollapsedBorderValue v(style->BorderLeft(), Color(255, 0, 0),
109 kBorderPrecedenceCell); 113 kBorderPrecedenceCell);
110 EXPECT_TRUE(v.Exists()); 114 EXPECT_TRUE(v.Exists());
111 EXPECT_EQ(5u, v.Width()); 115 EXPECT_EQ(5u, v.Width());
112 EXPECT_FALSE(v.IsTransparent()); 116 EXPECT_FALSE(v.IsTransparent());
113 EXPECT_TRUE(v.IsVisible()); 117 EXPECT_TRUE(v.IsVisible());
114 118
115 EXPECT_TRUE(v.IsSameIgnoringColor(v)); 119 EXPECT_TRUE(v.IsSameIgnoringColor(v));
116 EXPECT_TRUE(v.VisuallyEquals(v)); 120 EXPECT_TRUE(v.VisuallyEquals(v));
117 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue())); 121 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue()));
118 EXPECT_FALSE(v.VisuallyEquals(CollapsedBorderValue())); 122 EXPECT_FALSE(v.VisuallyEquals(CollapsedBorderValue()));
119 123
120 EXPECT_TRUE(v.IsSameIgnoringColor(CollapsedBorderValue( 124 EXPECT_TRUE(v.IsSameIgnoringColor(CollapsedBorderValue(
121 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell))); 125 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell)));
122 EXPECT_FALSE(v.VisuallyEquals(CollapsedBorderValue( 126 EXPECT_FALSE(v.VisuallyEquals(CollapsedBorderValue(
123 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell))); 127 style->BorderLeft(), Color(0, 255, 0), kBorderPrecedenceCell)));
124 128
125 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue( 129 EXPECT_FALSE(v.IsSameIgnoringColor(CollapsedBorderValue(
126 style->BorderLeft(), Color(255, 0, 0), kBorderPrecedenceTable))); 130 style->BorderLeft(), Color(255, 0, 0), kBorderPrecedenceTable)));
127 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue( 131 EXPECT_TRUE(v.VisuallyEquals(CollapsedBorderValue(
128 style->BorderLeft(), Color(255, 0, 0), kBorderPrecedenceTable))); 132 style->BorderLeft(), Color(255, 0, 0), kBorderPrecedenceTable)));
129 } 133 }
130 134
131 } // namespace blink 135 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698