Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2895623002: Remove HttpStreamFactoryImpl::Job::ssl_info_.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days ago by Bence
Modified:
15 minutes ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060

Patch Set 1 #

Patch Set 2 : Remove unused variable. #

Total comments: 4

Patch Set 3 : Re: #12. #

Messages

Total messages: 19 (15 generated)
Bence
xunjieli: PTAL. Thank you.
2 days, 20 hours ago (2017-05-19 19:02:24 UTC) #11
xunjieli
https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_factory_impl_job.cc#newcode567 net/http/http_stream_factory_impl_job.cc:567: GetSSLInfo(&ssl_info); GetSSLInfo() are called with the return value ignored. ...
2 days, 16 hours ago (2017-05-19 22:55:25 UTC) #12
Bence
xunjieli: Thank you for the review. PTAL. https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_factory_impl_job.cc#newcode567 net/http/http_stream_factory_impl_job.cc:567: GetSSLInfo(&ssl_info); On ...
1 day, 22 hours ago (2017-05-20 17:17:50 UTC) #18
xunjieli
15 minutes ago (2017-05-22 15:22:11 UTC) #19
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06