Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2895623002:
Remove HttpStreamFactoryImpl::Job::ssl_info_. (Closed)
DescriptionRemove HttpStreamFactoryImpl::Job::ssl_info_.
This member is not really used to store state long term,
so it cleaner to pass around an SSLInfo as function arguments.
Also, on an unrelated note, mark members |io_callback_|
and |delegate_| const.
BUG=475060
Review-Url: https://codereview.chromium.org/2895623002
Cr-Commit-Position: refs/heads/master@{#477746}
Committed: https://chromium.googlesource.com/chromium/src/+/b19de73fc2b4c2853bc7bf822865c1eab8e7146a
Patch Set 1 #Patch Set 2 : Remove unused variable. #
Total comments: 4
Patch Set 3 : Re: #12. #Patch Set 4 : Rebase. #Messages
Total messages: 32 (24 generated)
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, connection_->socket() was cast into an SSLClientSocket* at two places outside GetSSLInfo(), they could all rely on GetSSLInfo() instead. Also, on an unrelated note, mark member |delegate_| const. BUG=475060 ========== to ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, connection_->socket() was cast into an SSLClientSocket* at two places outside GetSSLInfo(), they could all rely on GetSSLInfo() instead. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
bnc@chromium.org changed reviewers: + xunjieli@chromium.org
xunjieli: PTAL. Thank you.
https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... net/http/http_stream_factory_impl_job.cc:567: GetSSLInfo(&ssl_info); GetSSLInfo() are called with the return value ignored. I don't quite like that. How about we keep GetSSLInfo returning void and handle RecordChannelIDKeyMatch separately? https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... net/http/http_stream_factory_impl_job.cc:1412: if (SSLClientSocket::IgnoreCertError(error, load_flags)) nice!
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, connection_->socket() was cast into an SSLClientSocket* at two places outside GetSSLInfo(), they could all rely on GetSSLInfo() instead. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060 ========== to ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
xunjieli: Thank you for the review. PTAL. https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... net/http/http_stream_factory_impl_job.cc:567: GetSSLInfo(&ssl_info); On 2017/05/19 22:55:25, xunjieli wrote: > GetSSLInfo() are called with the return value ignored. I don't quite like that. > How about we keep GetSSLInfo returning void and handle RecordChannelIDKeyMatch > separately? Done. https://codereview.chromium.org/2895623002/diff/20001/net/http/http_stream_fa... net/http/http_stream_factory_impl_job.cc:1412: if (SSLClientSocket::IgnoreCertError(error, load_flags)) On 2017/05/19 22:55:25, xunjieli wrote: > nice! An MSVC error message helped me realize that: when I first refactored, it claimed that |ssl_socket| was unused.
lgtm
Thank you for the review. This CL conflicts with revert https://crrev.com/2895263003 that landed yesterday, so I put this on hold until https://crrev.com/2814633003 is relanded. I'm removing reviewers so this does not show up in their queue.
bnc@chromium.org changed reviewers: - xunjieli@chromium.org
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bnc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xunjieli@chromium.org Link to the patchset: https://codereview.chromium.org/2895623002/#ps60001 (title: "Rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://crrev.com/2895263003 was reverted (https://crrev.com/2814633003 relanded) at https://crrev.com/2910463004, so this CL is ready to land.
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496866354248770,
"parent_rev": "8abf64aff97080b772d924ebf79d4c74d14eea0d", "commit_rev":
"b19de73fc2b4c2853bc7bf822865c1eab8e7146a"}
Message was sent while issue was closed.
Description was changed from ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060 ========== to ========== Remove HttpStreamFactoryImpl::Job::ssl_info_. This member is not really used to store state long term, so it cleaner to pass around an SSLInfo as function arguments. Also, on an unrelated note, mark members |io_callback_| and |delegate_| const. BUG=475060 Review-Url: https://codereview.chromium.org/2895623002 Cr-Commit-Position: refs/heads/master@{#477746} Committed: https://chromium.googlesource.com/chromium/src/+/b19de73fc2b4c2853bc7bf822865... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b19de73fc2b4c2853bc7bf822865... |
