Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2895613002: Return Request as unique_ptr from JobController::Start(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 3 hours ago by Bence
Modified:
4 days, 23 hours ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return Request as unique_ptr from JobController::Start(). Also return HttpStreamRequest as unique_ptr from RequestStream(), RequestWebSocketHandshakeStream(), RequestBidirectionalStreamImpl(), and RequestStreamInternal(). BUG=475060 Review-Url: https://codereview.chromium.org/2895613002 Cr-Commit-Position: refs/heads/master@{#473241} Committed: https://chromium.googlesource.com/chromium/src/+/f4bdc5a34983b679ca8b138ad493391b8220f807

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -111 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +16 lines, -15 lines 2 comments Download
M net/http/http_stream_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 4 chunks +15 lines, -12 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +6 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 27 chunks +54 lines, -54 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (8 generated)
Bence
Zhongyi: PTAL. Thank you. https://codereview.chromium.org/2895613002/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/2895613002/diff/1/net/http/http_network_transaction_unittest.cc#newcode15238 net/http/http_network_transaction_unittest.cc:15238: return std::move(fake_request); std::move is necessary ...
5 days, 1 hour ago (2017-05-19 15:55:10 UTC) #4
Bence
Also note that this is essentially the same at https://crrev.com/2893713004, which had to be reverted.
5 days ago (2017-05-19 17:42:42 UTC) #7
Zhongyi Shi
lgtm
4 days, 23 hours ago (2017-05-19 17:48:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895613002/1
4 days, 23 hours ago (2017-05-19 17:49:07 UTC) #10
commit-bot: I haz the power
4 days, 23 hours ago (2017-05-19 17:56:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4bdc5a34983b679ca8b138ad493...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06