Return Request as unique_ptr from JobController::Start().

net/http/http_network_transaction_unittest.cc

Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 8796b293bf1cfc7405d6d4859899c0d4ffc74e19..56b9a1838f05177a70aaa6b60ccbfb1dbc98be33 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -15224,20 +15224,21 @@ class FakeStreamFactory : public HttpStreamFactory {
     return last_stream_request_;
   }
 
-  HttpStreamRequest* RequestStream(const HttpRequestInfo& info,
-                                   RequestPriority priority,
-                                   const SSLConfig& server_ssl_config,
-                                   const SSLConfig& proxy_ssl_config,
-                                   HttpStreamRequest::Delegate* delegate,
-                                   bool enable_ip_based_pooling,
-                                   bool enable_alternative_services,
-                                   const NetLogWithSource& net_log) override {
-    FakeStreamRequest* fake_request = new FakeStreamRequest(priority, delegate);
+  std::unique_ptr<HttpStreamRequest> RequestStream(
+      const HttpRequestInfo& info,
+      RequestPriority priority,
+      const SSLConfig& server_ssl_config,
+      const SSLConfig& proxy_ssl_config,
+      HttpStreamRequest::Delegate* delegate,
+      bool enable_ip_based_pooling,
+      bool enable_alternative_services,
+      const NetLogWithSource& net_log) override {
+    auto fake_request = base::MakeUnique<FakeStreamRequest>(priority, delegate);
     last_stream_request_ = fake_request->AsWeakPtr();
-    return fake_request;
+    return std::move(fake_request);

[Bence, 2017/05/19 15:55:10]

std::move is necessary here because |fake_request| is
std::unique_ptr<FakeStreamRequest> whereas the function return type is
std::unique_ptr<HttpStreamRequest>.  Without this std::move, compilation fails
on some platforms.

   }
 
-  HttpStreamRequest* RequestBidirectionalStreamImpl(
+  std::unique_ptr<HttpStreamRequest> RequestBidirectionalStreamImpl(
       const HttpRequestInfo& info,
       RequestPriority priority,
       const SSLConfig& server_ssl_config,
@@ -15250,7 +15251,7 @@ class FakeStreamFactory : public HttpStreamFactory {
     return nullptr;
   }
 
-  HttpStreamRequest* RequestWebSocketHandshakeStream(
+  std::unique_ptr<HttpStreamRequest> RequestWebSocketHandshakeStream(
       const HttpRequestInfo& info,
       RequestPriority priority,
       const SSLConfig& server_ssl_config,
@@ -15260,10 +15261,10 @@ class FakeStreamFactory : public HttpStreamFactory {
       bool enable_ip_based_pooling,
       bool enable_alternative_services,
       const NetLogWithSource& net_log) override {
-    FakeStreamRequest* fake_request =
-        new FakeStreamRequest(priority, delegate, create_helper);
+    auto fake_request =
+        base::MakeUnique<FakeStreamRequest>(priority, delegate, create_helper);
     last_stream_request_ = fake_request->AsWeakPtr();
-    return fake_request;
+    return std::move(fake_request);

[Bence, 2017/05/19 15:55:10]

Same as above.

   }
 
   void PreconnectStreams(int num_streams,