Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issue 2895373002: Do not require Expect-CT report-uris to be quoted (Closed)

Created:
3 years, 7 months ago by estark
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not require Expect-CT report-uris to be quoted Requiring quoted URLs was cargo-culted from the HPKP implementation. The HPKP spec does not actually say that report-uris must be quoted -- it's simply that all the examples quote them. So it's possibly a bug that Chrome's HPKP implementation requires quoted report-uris. The Expect-CT spec doesn't say anything about quoting report-uris nor do I see a reason that it should, so Chrome's implementation shouldn't require them. BUG=679012 Review-Url: https://codereview.chromium.org/2895373002 Cr-Commit-Position: refs/heads/master@{#473959} Committed: https://chromium.googlesource.com/chromium/src/+/8ed543597520a61e2b12d8ed6fef02e97171a5d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M net/http/http_security_headers.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
estark
mattm, PTAL?
3 years, 7 months ago (2017-05-22 22:56:35 UTC) #5
mattm
lgtm
3 years, 7 months ago (2017-05-23 17:28:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895373002/1
3 years, 7 months ago (2017-05-23 17:29:53 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:35:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ed543597520a61e2b12d8ed6fef...

Powered by Google App Engine
This is Rietveld 408576698