Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: net/http/http_security_headers.cc

Issue 2895373002: Do not require Expect-CT report-uris to be quoted (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_security_headers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_security_headers.cc
diff --git a/net/http/http_security_headers.cc b/net/http/http_security_headers.cc
index 9df02cfb9a5ebbe7f5523fc853b6909438542085..e67eadf7febe37c8563da89b1c2c364feaf6e9a4 100644
--- a/net/http/http_security_headers.cc
+++ b/net/http/http_security_headers.cc
@@ -368,7 +368,7 @@ bool ParseHPKPReportOnlyHeader(const std::string& value,
// "Expect-CT" ":"
// "max-age" "=" delta-seconds
// [ "," "enforce" ]
-// [ "," "report-uri" "=" uri-reference ]
+// [ "," "report-uri" "=" absolute-URI ]
bool ParseExpectCTHeader(const std::string& value,
base::TimeDelta* max_age,
bool* enforce,
@@ -413,9 +413,6 @@ bool ParseExpectCTHeader(const std::string& value,
// field."
if (has_report_uri)
return false;
- // report-uris are always quoted.
- if (!name_value_pairs.value_is_quoted())
- return false;
has_report_uri = true;
parsed_report_uri = GURL(base::StringPiece(name_value_pairs.value_begin(),
« no previous file with comments | « no previous file | net/http/http_security_headers_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698