Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2895353002: Fix host resolver being initialized after network requests arrive to the network service. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
yzshen1, Will Harris
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix host resolver being initialized after network requests arrive to the network service. This regressed in r472101 wich made the network service pointer get initialized in non-test code earlier. BUG=720374 Review-Url: https://codereview.chromium.org/2895353002 Cr-Commit-Position: refs/heads/master@{#473774} Committed: https://chromium.googlesource.com/chromium/src/+/34b5e4d8973b34420533e465f0124504349ac72e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/public/common/network_service_test.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
jam
3 years, 7 months ago (2017-05-22 23:11:26 UTC) #4
yzshen1
lgtm
3 years, 7 months ago (2017-05-22 23:15:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895353002/1
3 years, 7 months ago (2017-05-22 23:24:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444304)
3 years, 7 months ago (2017-05-22 23:34:38 UTC) #10
jam
+Tom for mojom change
3 years, 7 months ago (2017-05-23 00:33:55 UTC) #12
Will Harris
lgtm for mojom
3 years, 7 months ago (2017-05-23 01:15:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895353002/1
3 years, 7 months ago (2017-05-23 01:17:08 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 01:21:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34b5e4d8973b34420533e465f012...

Powered by Google App Engine
This is Rietveld 408576698