Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: content/shell/utility/shell_content_utility_client.cc

Issue 2895353002: Fix host resolver being initialized after network requests arrive to the network service. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/network_service_test.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/utility/shell_content_utility_client.cc
diff --git a/content/shell/utility/shell_content_utility_client.cc b/content/shell/utility/shell_content_utility_client.cc
index 69d156bba03461301c3357bdf5c7914563e53ecb..47a786080a5ccdd1994b9a3f871f0a9a9485b7c2 100644
--- a/content/shell/utility/shell_content_utility_client.cc
+++ b/content/shell/utility/shell_content_utility_client.cc
@@ -90,11 +90,13 @@ class NetworkServiceTestImpl : public mojom::NetworkServiceTest {
~NetworkServiceTestImpl() override = default;
// mojom::NetworkServiceTest implementation.
- void AddRules(std::vector<mojom::RulePtr> rules) override {
+ void AddRules(std::vector<mojom::RulePtr> rules,
+ AddRulesCallback callback) override {
for (const auto& rule : rules) {
test_host_resolver_.host_resolver()->AddRule(rule->host_pattern,
rule->replacement);
}
+ std::move(callback).Run();
}
private:
« no previous file with comments | « content/public/common/network_service_test.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698