Android: tidy up outdated version checks.

Android: tidy up outdated version checks.

Fix various outdated version checks in the Android code:

1) Remove comparisons to Build.VERSION.CODENAME that refer to released
   SDKs and replace with correct SDK_INT comparisons instead.

2) Compare SDK_INT to constants instead of integer literals.

3) Remove old ICS-only code from NFC BeamCallback since we don't support
   pre-JB any more.

BUG=724622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2895293002
Cr-Commit-Position: refs/heads/master@{#473998}
Committed: https://chromium.googlesource.com/chromium/src/+/f494f8655828bca8094e8a71a9bda2ecdddd280d

[Torne, 2017-05-22 15:56:51]

Description was changed from

==========
Android: tidy up outdated version checks.

Fix various outdated version checks in the Android code:

1) Remove comparisons to Build.VERSION.CODENAME that refer to released
   SDKs and replace with correct SDK_INT comparisons instead.

2) Compare SDK_INT to constants instead of integer literals.

3) Remove old ICS-only code from NFC BeamCallback since we don't support
   pre-JB any more.

BUG=724622
==========

to

==========
Android: tidy up outdated version checks.

Fix various outdated version checks in the Android code:

1) Remove comparisons to Build.VERSION.CODENAME that refer to released
   SDKs and replace with correct SDK_INT comparisons instead.

2) Compare SDK_INT to constants instead of integer literals.

3) Remove old ICS-only code from NFC BeamCallback since we don't support
   pre-JB any more.

BUG=724622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Torne, 2017-05-22 15:57:24]

The CQ bit was checked by torne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 15:57:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Torne, 2017-05-22 15:58:53]

torne@chromium.org changed reviewers:
+ nyquist@chromium.org

[Torne, 2017-05-22 15:58:54]

Tommy, I went through looking for outdated checks and cleaned up everything I
could find. None of these are actually incorrect but they're all "bad examples"
that I don't want people to copy :)

Can you do an initial review on the whole CL, and I'll find OWNERS for it after?

[Torne, 2017-05-22 15:59:50]

I'm looking at how to add a presubmit/findbugs/checkstyle/something check to
prevent people regressing this, also.

There was one dubious check I'm not sure about so asked on the original CL here:
https://codereview.chromium.org/2058113002/

[commit-bot: I haz the power, 2017-05-22 17:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:06:00]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-05-22 20:53:52]

looked through all of it. And yeah, I agree that
MediaCodecUtil#platformSupportsCbcsEncryption() looks dubious in relationship to
N_MR1.

Anyway, this CL LGTM as is. Thanks!

[Torne, 2017-05-23 15:31:09]

torne@chromium.org changed reviewers:
+ liberato@chromium.org

[Torne, 2017-05-23 15:31:10]

liberato: can you review media/ for OWNERS please?

[liberato (no reviews please), 2017-05-23 16:27:00]

media/ lgtm.  thanks for the cleanup!

-fl

[Torne, 2017-05-23 16:50:22]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:51:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:42:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495558222002980, "parent_rev":
"9e5c20b710a753c0992126b1176015849400ca31", "commit_rev":
"f494f8655828bca8094e8a71a9bda2ecdddd280d"}

[commit-bot: I haz the power, 2017-05-23 18:43:07]

Description was changed from

==========
Android: tidy up outdated version checks.

Fix various outdated version checks in the Android code:

1) Remove comparisons to Build.VERSION.CODENAME that refer to released
   SDKs and replace with correct SDK_INT comparisons instead.

2) Compare SDK_INT to constants instead of integer literals.

3) Remove old ICS-only code from NFC BeamCallback since we don't support
   pre-JB any more.

BUG=724622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Android: tidy up outdated version checks.

Fix various outdated version checks in the Android code:

1) Remove comparisons to Build.VERSION.CODENAME that refer to released
   SDKs and replace with correct SDK_INT comparisons instead.

2) Compare SDK_INT to constants instead of integer literals.

3) Remove old ICS-only code from NFC BeamCallback since we don't support
   pre-JB any more.

BUG=724622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2895293002
Cr-Commit-Position: refs/heads/master@{#473998}
Committed:
https://chromium.googlesource.com/chromium/src/+/f494f8655828bca8094e8a71a9bd...
==========

[commit-bot: I haz the power, 2017-05-23 18:43:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f494f8655828bca8094e8a71a9bd...