chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java - Issue 2895293002: Android: tidy up outdated version checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java

Issue 2895293002: Android: tidy up outdated version checks. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java ('k') | media/base/android/java/src/org/chromium/media/MediaCodecUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java

index 2bb84bc738b82baaae2d6c1911180f051f70f20d..e94d8a4fee1417709b2f2ef0c464bbcc9acf03af 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeUnitTest.java

@@ -15,7 +15,6 @@ import android.os.Build;

import org.junit.After;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.robolectric.annotation.Config;

import org.chromium.base.CommandLine;

@@ -65,9 +64,7 @@ public class NotificationPlatformBridgeUnitTest {

CommandLine.reset();

CommandLine.init(null);

- boolean isNougatOrNewer = Build.VERSION.CODENAME.equals("N")

- || Build.VERSION.SDK_INT > 23 /* Build.VERSION_CODES.M */;

- if (isNougatOrNewer) {

+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {

// Without comand line flags, custom layouts are always disabled on Nougat+.

assertFalse(NotificationPlatformBridge.useCustomLayouts(false /* hasImage */));

assertFalse(NotificationPlatformBridge.useCustomLayouts(true /* hasImage */));