Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)
Patch Set: webkit tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 0499bd8a40f5638ac11bcea5e7f31fe8159c0fa7..0442e3c9be0df1a3ea267c0f467e7237780d32ad 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -425,6 +425,12 @@ String Deprecation::DeprecationMessage(UseCounter::Feature feature) {
"recent-changes-credential-management-api for migration suggestions.",
milestoneString(M62));
+ case UseCounter::kCredentialManagerRequireUserMediation:
+ return String::Format(
+ "'requireUserMediation' was renamed to 'preventSilentAccess'. The "
+ "method will be removed in %s.",
+ milestoneString(M62));
Mike West 2017/05/23 18:54:32 Nit: I'd suggest something like: ``` return repla
vasilii 2017/05/24 10:02:13 Done.
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698