third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html - Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)

Patch Set: webkit tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/common/credential_manager.mojom ('K') | « third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html ('k') | third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/iframed-credentialscontainer.html » ('j') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html

index 9df20f44757f1bb0ebc7437e9061177208365a0f..77e7bb5e6c437ba4481e1e99d486ad628a391d6c 100644

--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html

+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

Mike West 2017/05/23 18:54:32 Nit: Can you copy this test so that we keep some c

vasilii 2017/05/24 10:02:13 Done.

-<title>Credential Manager: requireUserMediation() basics.</title>

+<title>Credential Manager: preventSilentAccess() basics.</title>

@@ -9,12 +9,12 @@ function stubResolverChecker(c) {

}

function stubRejectionChecker(reason) {

- assert_unreached("requireUserMediation() should not reject, but did: " + reason.name);

+ assert_unreached("preventSilentAccess() should not reject, but did: " + reason.name);

}

async_test(function () {

- navigator.credentials.requireUserMediation().then(

+ navigator.credentials.preventSilentAccess().then(

this.step_func(stubResolverChecker.bind(this)),

this.step_func(stubRejectionChecker.bind(this)));

-}, "Verify the basics of requireUserMediation()");

+}, "Verify the basics of preventSilentAccess()");

</script>