components/password_manager/content/common/credential_manager.mojom - Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager.mojom

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)

Patch Set: webkit tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl_unittest.cc ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager.mojom

diff --git a/components/password_manager/content/common/credential_manager.mojom b/components/password_manager/content/common/credential_manager.mojom

index cea374c736e9bc256283cbfd94f50c5691de1840..1b25739566eaaa79fcfd3adcc414851a601295d5 100644

--- a/components/password_manager/content/common/credential_manager.mojom

+++ b/components/password_manager/content/common/credential_manager.mojom

@@ -41,7 +41,7 @@ interface CredentialManager {

Store(CredentialInfo credential) => ();

// Require user mediation. For navigator.credentials.requireUserMediation().

Mike West 2017/05/23 18:54:32 Nit: Replace here too.

vasilii 2017/05/24 10:02:13 Done.

- RequireUserMediation() => ();

+ PreventSilentAccess() => ();

// Get Credential. For navigator.credentials.get().

// The result callback will return a non-null and valid CredentialInfo