Fixing glitch about Sign-in promo height in bookmarks

Fixing glitch about Sign-in promo height in bookmarks

-[BookmarkFolderCollectionView cellSizeForIndexPath:] can use the
current cell to compute its height when reloading. So when
BookmarkFolderCollectionView receives the notification to update the
SigninPromoView, the view has to be updated even if the section is
reloaded.

BUG=725040
Review-Url: https://codereview.chromium.org/2895173003
Cr-Commit-Position: refs/heads/master@{#473868}
Committed: https://chromium.googlesource.com/chromium/src/+/50dd2bde25f729081248de4c835d1ef99c695754

[jlebel, 2017-05-22 18:10:44]

jlebel@chromium.org changed reviewers:
+ lpromero@chromium.org

[jlebel, 2017-05-22 18:10:44]

Hello Louis,

Can you review this patch?

Thanks,

[lpromero, 2017-05-23 09:27:18]

lgtm

https://codereview.chromium.org/2895173003/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm (right):

https://codereview.chromium.org/2895173003/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm:556: //
-[BookmarkFolderCollectionView cellSizeForIndexPath:] uses the current
The electrical current? The river's current? :)

[jlebel, 2017-05-23 12:24:07]

https://codereview.chromium.org/2895173003/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm (right):

https://codereview.chromium.org/2895173003/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm:556: //
-[BookmarkFolderCollectionView cellSizeForIndexPath:] uses the current
On 2017/05/23 09:27:18, lpromero wrote:
> The electrical current? The river's current? :)

All currents!

[jlebel, 2017-05-23 12:24:11]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-05-23 12:24:19]

The CQ bit was unchecked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-05-23 12:24:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-05-23 12:25:29]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-05-23 12:25:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2895173003/#ps20001
(title: "Current")

[commit-bot: I haz the power, 2017-05-23 12:25:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 12:37:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495542329021830,
"parent_rev": "c37e844a6f87088261bf3c595ea34b64b15f1633", "commit_rev":
"50dd2bde25f729081248de4c835d1ef99c695754"}

[commit-bot: I haz the power, 2017-05-23 12:37:46]

Description was changed from

==========
Fixing glitch about Sign-in promo height in bookmarks

-[BookmarkFolderCollectionView cellSizeForIndexPath:] can use the
current cell to compute its height when reloading. So when
BookmarkFolderCollectionView receives the notification to update the
SigninPromoView, the view has to be updated even if the section is
reloaded.

BUG=725040
==========

to

==========
Fixing glitch about Sign-in promo height in bookmarks

-[BookmarkFolderCollectionView cellSizeForIndexPath:] can use the
current cell to compute its height when reloading. So when
BookmarkFolderCollectionView receives the notification to update the
SigninPromoView, the view has to be updated even if the section is
reloaded.

BUG=725040

Review-Url: https://codereview.chromium.org/2895173003
Cr-Commit-Position: refs/heads/master@{#473868}
Committed:
https://chromium.googlesource.com/chromium/src/+/50dd2bde25f729081248de4c835d...
==========

[commit-bot: I haz the power, 2017-05-23 12:37:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/50dd2bde25f729081248de4c835d...