Fixing glitch about Sign-in promo height in bookmarks

ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h"
 
 #include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "ios/chrome/browser/bookmarks/bookmarks_utils.h"
@@ skipping 527 matching lines @@
 - (BOOL)shouldShowPromoCell {
   return _promoVisible;
 }
 
 #pragma mark - SigninPromoViewConsumer
 
 - (void)configureSigninPromoViewWithNewIdentity:(BOOL)newIdentity
                                    configurator:(SigninPromoViewConfigurator*)
                                                     configurator {
   DCHECK(_signinPromoViewMediator);
-  if (newIdentity) {
-    NSIndexSet* indexSet = [NSIndexSet indexSetWithIndex:self.promoSection];
-    [self.collectionView reloadSections:indexSet];
-    return;
-  }
   NSIndexPath* indexPath =
       [NSIndexPath indexPathForRow:0 inSection:self.promoSection];
   BookmarkSigninPromoCell* signinPromoCell =
       static_cast<BookmarkSigninPromoCell*>(
           [self.collectionView cellForItemAtIndexPath:indexPath]);
   if (!signinPromoCell)
     return;
+  // Should always reconfigure the cell size even if it has to be reloaded.
+  // -[BookmarkFolderCollectionView cellSizeForIndexPath:] uses the current

[lpromero, 2017/05/23 09:27:18]

The electrical current? The river's current? :)

[jlebel, 2017/05/23 12:24:07]

All currents!

+  // to compute its height.
   [configurator configureSigninPromoView:signinPromoCell.signinPromoView];
+  if (newIdentity) {
+    // The section should be reload to update the cell height.
+    NSIndexSet* indexSet = [NSIndexSet indexSetWithIndex:self.promoSection];
+    [self.collectionView reloadSections:indexSet];
+  }
 }
 
 @end