Fix the white background regression on the Extensions overflow menu.

Fix the white background regression on the Extensions overflow menu.

This was a regression introduced by my patch https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for 
the suggestions.

BUG=722965
Review-Url: https://codereview.chromium.org/2895003002
Cr-Commit-Position: refs/heads/master@{#473787}
Committed: https://chromium.googlesource.com/chromium/src/+/9c46717e8d85b283ccb79dd4e305d33ba99b1432

[ananta, 2017-05-19 22:05:49]

Description was changed from

==========
Fix the white background regression on the Extensions overflow menu.

This was a regression introduced by my patch
https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when
a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the
viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the
scrollview to ensure that
transparent views like the overflow menu work correctly.

BUG=722965
==========

to

==========
Fix the white background regression on the Extensions overflow menu.

This was a regression introduced by my patch
https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when
a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the
viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the
scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for 
the suggestions.

BUG=722965
==========

[ananta, 2017-05-19 22:07:12]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-05-19 22:07:25]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:07:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-05-19 22:08:22]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:08:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:00:28]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-22 16:23:40]

https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
File ui/views/controls/scroll_view.cc (right):

https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
ui/views/controls/scroll_view.cc:751: contents_viewport_->SetPaintToLayer();
Does supplying LAYER_SOLID_COLOR work for your needs? That's preferable as a
solid color layer takes up less gpu memory.

[ananta, 2017-05-22 19:22:43]

https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
File ui/views/controls/scroll_view.cc (right):

https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
ui/views/controls/scroll_view.cc:751: contents_viewport_->SetPaintToLayer();
On 2017/05/22 16:23:40, sky wrote:
> Does supplying LAYER_SOLID_COLOR work for your needs? That's preferable as a
> solid color layer takes up less gpu memory.

Sadly no. The content does not show up.

[sky, 2017-05-22 21:14:30]

On 2017/05/22 19:22:43, ananta wrote:
>
https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
> File ui/views/controls/scroll_view.cc (right):
> 
>
https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
> ui/views/controls/scroll_view.cc:751: contents_viewport_->SetPaintToLayer();
> On 2017/05/22 16:23:40, sky wrote:
> > Does supplying LAYER_SOLID_COLOR work for your needs? That's preferable as a
> > solid color layer takes up less gpu memory.
> 
> Sadly no. The content does not show up.

Did you set the background color of the layer to totally transparent?

[ananta, 2017-05-22 22:16:39]

On 2017/05/22 21:14:30, sky wrote:
> On 2017/05/22 19:22:43, ananta wrote:
> >
>
https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
> > File ui/views/controls/scroll_view.cc (right):
> > 
> >
>
https://codereview.chromium.org/2895003002/diff/20001/ui/views/controls/scrol...
> > ui/views/controls/scroll_view.cc:751: contents_viewport_->SetPaintToLayer();
> > On 2017/05/22 16:23:40, sky wrote:
> > > Does supplying LAYER_SOLID_COLOR work for your needs? That's preferable as
a
> > > solid color layer takes up less gpu memory.
> > 
> > Sadly no. The content does not show up.
> 
> Did you set the background color of the layer to totally transparent?

The background color of the underlying layer (cc_layer) is 0, which is
SK_ColorTRANSPARENT.

[sky, 2017-05-22 22:20:06]

What I suggested doesn't make sense because we still need child views to paint.
Ok, LGTM

[ananta, 2017-05-23 01:20:25]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:21:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:13:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495502425671010,
"parent_rev": "ea8d0167edd856fc587d630b9b2d635cefab5798", "commit_rev":
"ee6a4f16af208f876a440922b314a10be9952d0f"}

[commit-bot: I haz the power, 2017-05-23 02:13:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495502425671010,
"parent_rev": "4d47b5db0e581826d6a37b4448cc0509c7fc5472", "commit_rev":
"9c46717e8d85b283ccb79dd4e305d33ba99b1432"}

[commit-bot: I haz the power, 2017-05-23 02:13:34]

Description was changed from

==========
Fix the white background regression on the Extensions overflow menu.

This was a regression introduced by my patch
https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when
a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the
viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the
scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for 
the suggestions.

BUG=722965
==========

to

==========
Fix the white background regression on the Extensions overflow menu.

This was a regression introduced by my patch
https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when
a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the
viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the
scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for 
the suggestions.

BUG=722965

Review-Url: https://codereview.chromium.org/2895003002
Cr-Commit-Position: refs/heads/master@{#473787}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c46717e8d85b283ccb79dd4e305...
==========

[commit-bot: I haz the power, 2017-05-23 02:13:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c46717e8d85b283ccb79dd4e305...