Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: ui/views/view_unittest.cc

Issue 2895003002: Fix the white background regression on the Extensions overflow menu. (Closed)
Patch Set: Fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/controls/scroll_view.cc ('K') | « ui/views/controls/scroll_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view_unittest.cc
diff --git a/ui/views/view_unittest.cc b/ui/views/view_unittest.cc
index caafd8b92dc7e72b2872354216024e7d4e73e0d4..d71f0f6fd792faaceb9f806f1226517a6423c4d5 100644
--- a/ui/views/view_unittest.cc
+++ b/ui/views/view_unittest.cc
@@ -5039,6 +5039,12 @@ TEST_F(ViewObserverTest, ScrollViewChildAddLayerTest) {
child_view->SetPaintToLayer(ui::LAYER_TEXTURED);
EXPECT_TRUE(scroll_view->contents_viewport_->layer());
+ // We don't want the viewport's layer to have the fill_bounds_opaquely() bit
+ // set, as we may have transparent children who want to blend into the
+ // default background.
+ EXPECT_FALSE(
+ scroll_view->contents_viewport_->layer()->fills_bounds_opaquely());
+
scroll_view->RemoveChildView(child_view.get());
}
« ui/views/controls/scroll_view.cc ('K') | « ui/views/controls/scroll_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698