Gather UMA for click retarget due to DOM changes

Gather UMA for click retarget due to DOM changes

If the mouse down element is removed from DOM
and gets added back we do not send a click event.
This change adds the UMA metric to see how often
this happens. Also enables sending that click
event behind flag to see the effect in the wild.

BUG=716694
Review-Url: https://codereview.chromium.org/2894963002
Cr-Commit-Position: refs/heads/master@{#474841}
Committed: https://chromium.googlesource.com/chromium/src/+/facebe17862d084a9100cebc46d126b4d1d6773b

[Navid Zolghadr, 2017-05-19 18:35:36]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2017-05-19 18:36:36]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:36:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:10:56]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-05-22 09:08:04]

lgtm

[Navid Zolghadr, 2017-05-23 14:22:30]

nzolghadr@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Navid Zolghadr, 2017-05-23 14:22:30]

rkaplow: Please review changes in 

tools/metrics/histogram.xml

[rkaplow, 2017-05-24 17:26:13]

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15795: +<histogram
name="Event.ClickNotFiredDueToDomManipulation">
can you add the enum (Boolean)

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15798: +    Number of times click target
would be affected by DOM manipulation.   Team:
This isn't really the "number of times" since you're measuring a boolean. I
would describe this as if it was one event.

[Navid Zolghadr, 2017-05-24 20:49:24]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2017-05-24 20:49:48]

ptal

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15795: +<histogram
name="Event.ClickNotFiredDueToDomManipulation">
On 2017/05/24 17:26:13, rkaplow wrote:
> can you add the enum (Boolean)

Done.

https://codereview.chromium.org/2894963002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:15798: +    Number of times click target
would be affected by DOM manipulation.   Team:
On 2017/05/24 17:26:13, rkaplow wrote:
> This isn't really the "number of times" since you're measuring a boolean. I
> would describe this as if it was one event.

Done.

[commit-bot: I haz the power, 2017-05-24 20:49:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:53:35]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-05-25 20:52:35]

lgtm

[Navid Zolghadr, 2017-05-25 20:56:30]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-05-25 20:56:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2894963002/#ps20001
(title: "Add boolean to the type of the histogram")

[commit-bot: I haz the power, 2017-05-25 20:57:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 23:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495745790766140,
"parent_rev": "e41110282f606e040748caf49c50eb04fecb3eb3", "commit_rev":
"facebe17862d084a9100cebc46d126b4d1d6773b"}

[commit-bot: I haz the power, 2017-05-25 23:28:27]

Description was changed from

==========
Gather UMA for click retarget due to DOM changes

If the mouse down element is removed from DOM
and gets added back we do not send a click event.
This change adds the UMA metric to see how often
this happens. Also enables sending that click
event behind flag to see the effect in the wild.

BUG=716694
==========

to

==========
Gather UMA for click retarget due to DOM changes

If the mouse down element is removed from DOM
and gets added back we do not send a click event.
This change adds the UMA metric to see how often
this happens. Also enables sending that click
event behind flag to see the effect in the wild.

BUG=716694

Review-Url: https://codereview.chromium.org/2894963002
Cr-Commit-Position: refs/heads/master@{#474841}
Committed:
https://chromium.googlesource.com/chromium/src/+/facebe17862d084a9100cebc46d1...
==========

[commit-bot: I haz the power, 2017-05-25 23:28:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/facebe17862d084a9100cebc46d1...