third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html - Issue 2894963002: Gather UMA for click retarget due to DOM changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html

Issue 2894963002: Gather UMA for click retarget due to DOM changes (Closed)

Patch Set: Add boolean to the type of the histogram Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html b/third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html

index fb67518cd29089d336d2fb6aa992a8add5efb8a8..e46d99eedb308698bef670eae1e8ee2c518cb625 100644

--- a/third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html

+++ b/third_party/WebKit/LayoutTests/fast/events/remove-target-in-mouseup-insertback.html

@@ -2,14 +2,13 @@

<html>

<body>

<p>This test ensures WebKit does not fire click event on a node that has been removed and inserted back in mouseup event.</p>

-<div id="test"><span id="target" onmouseup="mouseup()" onclick="test.innerHTML = 'FAIL';">click here</span></div>

+<div id="test"><span id="target" onmouseup="mouseup()" onclick="test.innerHTML = 'PASS';">click here</span></div>

var test = document.getElementById('test');

var target = document.getElementById('target');

function mouseup() {

- test.appendChild(document.createTextNode('PASS'));

test.removeChild(target);

test.appendChild(target);

}

@@ -23,7 +22,6 @@ if (window.testRunner) {

eventSender.mouseDown();

eventSender.leapForward(200);

eventSender.mouseUp();

- test.removeChild(target);

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/MouseEventManager.h » ('j') | no next file with comments »