Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2894953003: Revert of cc : Don't draw animating layers which are transparent but raster them. (Closed)

Created:
3 years, 7 months ago by jaydasika
Modified:
3 years, 7 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, vmpstr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Don't draw animating layers which are transparent but raster them. (patchset #2 id:20001 of https://codereview.chromium.org/2858853002/ ) Reason for revert: Could be the cause of crbug.com/724591 Original issue's description: > cc : Don't draw animating layers which are transparent but raster them. > > This is similar to https://codereview.chromium.org/2838033002/ where > we do that same thing for animating layers with singular transform > > BUG=717818 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > TBR=enne@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=717818 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2894953003 Cr-Commit-Position: refs/heads/master@{#473308} Committed: https://chromium.googlesource.com/chromium/src/+/50612fa00dfc8e79fe5bc92e2f235eee645739e9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +4 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 3 chunks +25 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jaydasika
Created Revert of cc : Don't draw animating layers which are transparent but raster them.
3 years, 7 months ago (2017-05-19 19:27:43 UTC) #1
weiliangc
LGTM, thanks.
3 years, 7 months ago (2017-05-19 19:30:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894953003/120001
3 years, 7 months ago (2017-05-19 19:36:39 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 20:56:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/50612fa00dfc8e79fe5bc92e2f23...

Powered by Google App Engine
This is Rietveld 408576698