Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2894913003: [TTS] Move Ranker logging to inference time.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 21 hours ago by Donn Denman
Modified:
19 hours, 40 minutes ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Move Ranker logging to inference time. Changes logging of Ranker features to make sure they are done at inference-time or beforehand, instead of allowing them to be done after inference. Logging of outcomes can be done at any time. Adds a queue for all the features so they can all be logged at the same time, or the logging can easily be aborted at the last minute. Updates handling of before-scroll to have a configurable pause to allow scrolling after a Tap has been recognized. Before-scroll is no longer considered a Ranker-feature: It's handled by the normal detection of any action that can dismiss the panel during the time between a tap and showing the UI. Updates UKM feature-names from all-caps to camelcase. Removes the Before-scroll feature from Ranker logging through UKM. Also remove some leftover Blacklist code that's no longer needed. BUG=721588

Patch Set 1 #

Patch Set 2 : Fix some asserts and minor cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -118 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java View 1 6 chunks +23 lines, -36 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/BarOverlapTapSuppression.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 4 chunks +19 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 6 chunks +45 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java View 1 4 chunks +23 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java View 1 4 chunks +81 lines, -44 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/CtrSuppression.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/QuickAnswersHeuristic.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/RecentScrollTapSuppression.java View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +20 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (6 generated)
Donn Denman
19 hours, 40 minutes ago (2017-05-23 22:10:48 UTC) #7
Theresa, PTAL at your leisure.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06