Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2235)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 2894913003: [TTS] Move Ranker logging to inference time. (Closed)
Patch Set: Rebase only. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index db5262a3bd1952bd8b2c7fa3203c46d01dda1784..8f2fd64457cb0c620ccc4f06efa757f5c5dd9eaf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -32,7 +32,7 @@ public class ContextualSearchFieldTrial {
private static final int PEEK_PROMO_DEFAULT_MAX_SHOW_COUNT = 10;
private static final String DISABLE_SEARCH_TERM_RESOLUTION = "disable_search_term_resolution";
- private static final String ENABLE_BLACKLIST = "enable_blacklist";
+ private static final String WAIT_AFTER_TAP_DELAY_MS = "wait_after_tap_delay_ms";
// Translation. All these members are private, except for usage by testing.
// Master switch, needed to disable all translate code for Contextual Search in case of an
@@ -86,6 +86,7 @@ public class ContextualSearchFieldTrial {
private static Boolean sIsPageContentNotificationDisabled;
private static Boolean sContextualSearchUrlActionsEnabled;
private static Boolean sIsRankerLoggingEnabled;
+ private static Integer sWaitAfterTapDelayMs;
/**
* Don't instantiate.
@@ -182,13 +183,6 @@ public class ContextualSearchFieldTrial {
}
/**
- * @return Whether the blacklist is enabled.
- */
- static boolean isBlacklistEnabled() {
- return getBooleanParam(ENABLE_BLACKLIST);
- }
-
- /**
* @return The maximum number of times the Peek Promo should be displayed.
*/
static int getPeekPromoMaxShowCount() {
@@ -316,9 +310,23 @@ public class ContextualSearchFieldTrial {
return sIsRankerLoggingEnabled;
}
- // ---------------
- // Features.
- // ---------------
+ /**
+ * Gets an amount to delay after a Tap gesture is recognized, in case some user gesture
+ * immediately follows that would prevent the UI from showing.
+ * The classic example is a scroll, which might be a signal that the previous tap was
+ * accidental.
+ * @return The delay in MS after the Tap before showing any UI.
+ */
+ static int getWaitAfterTapDelayMs() {
+ if (sWaitAfterTapDelayMs == null) {
+ sWaitAfterTapDelayMs = getIntParamValueOrDefault(WAIT_AFTER_TAP_DELAY_MS, 0);
+ }
+ return sWaitAfterTapDelayMs.intValue();
+ }
+
+ // ---------------------------
+ // Feature-controlled Switches
+ // ---------------------------
/**
* @return Whether or not single actions based on Contextual Cards is enabled.

Powered by Google App Engine
This is Rietveld 408576698