Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894883004: Removed IsNativeAppLauncherEnabled() experiment (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, ios-reviews+clean_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed IsNativeAppLauncherEnabled() experiment The experiment flag is removed as well as the first layer of code that is now unreachable. Subsequent CLs will remove additional code from the code base. BUG=721921 Review-Url: https://codereview.chromium.org/2894883004 Cr-Commit-Position: refs/heads/master@{#481156} Committed: https://chromium.googlesource.com/chromium/src/+/2596c5101b8b875c48fb6eed2461ef0f7eff838b

Patch Set 1 #

Patch Set 2 : removed setting from Experimental.plist #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 4

Patch Set 5 : renamed mainBrowserState to browserState #

Patch Set 6 : comment explaining a DCHECK. #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -464 lines) Patch
M ios/chrome/app/main_controller.mm View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 2 3 4 5 6 7 1 chunk +0 lines, -10 lines 0 comments Download
M ios/chrome/browser/tabs/tab.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 2 3 4 5 6 7 8 chunks +0 lines, -67 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 3 4 5 6 7 4 chunks +0 lines, -190 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 2 3 4 5 6 7 2 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm View 4 chunks +5 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm View 2 chunks +3 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.h View 1 2 3 4 1 chunk +3 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.mm View 1 2 3 4 5 6 7 20 chunks +32 lines, -61 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 2 3 4 5 6 7 3 chunks +0 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.mm View 1 chunk +1 line, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm View 4 chunks +0 lines, -8 lines 0 comments Download
M ios/chrome/browser/web/external_app_launcher.mm View 2 chunks +1 line, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/settings/settings_coordinator.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 3 4 5 6 3 chunks +3 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pkl (ping after 24h if needed)
I will NOT be landing this CL until M60 branch has been cut. Exact date ...
3 years, 7 months ago (2017-05-25 01:38:07 UTC) #3
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2894883004/diff/60001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h File ios/chrome/browser/ui/settings/settings_collection_view_controller.h (right): https://codereview.chromium.org/2894883004/diff/60001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h#newcode42 ios/chrome/browser/ui/settings/settings_collection_view_controller.h:42: - (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)mainBrowserState nit: Should this be just |browserState|? ...
3 years, 7 months ago (2017-05-25 14:47:33 UTC) #4
pkl (ping after 24h if needed)
https://codereview.chromium.org/2894883004/diff/60001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h File ios/chrome/browser/ui/settings/settings_collection_view_controller.h (right): https://codereview.chromium.org/2894883004/diff/60001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h#newcode42 ios/chrome/browser/ui/settings/settings_collection_view_controller.h:42: - (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)mainBrowserState On 2017/05/25 14:47:33, Eugene But wrote: > ...
3 years, 7 months ago (2017-05-26 17:34:18 UTC) #5
rohitrao (ping after 24h)
lgtm We're definitely killing the feature in M60? We have all the approvals that we ...
3 years, 6 months ago (2017-05-30 14:35:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894883004/140001
3 years, 6 months ago (2017-06-21 09:17:11 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 09:27:07 UTC) #12
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/2596c5101b8b875c48fb6eed2461...

Powered by Google App Engine
This is Rietveld 408576698