ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm - Issue 2894883004: Removed IsNativeAppLauncherEnabled() experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

Issue 2894883004: Removed IsNativeAppLauncherEnabled() experiment (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/settings_collection_view_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

index 9a68fe64afeffd613bd19510c06bc0d649cf7081..c584ff49683a87f1989096773817c5a5168bcf21 100644

--- a/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

@@ -5,7 +5,6 @@

#import "ios/chrome/browser/ui/settings/content_settings_collection_view_controller.h"

#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"

-#include "ios/chrome/browser/experimental_flags.h"

#import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.h"

#import "ios/chrome/browser/ui/collection_view/collection_view_controller_test.h"

#include "ios/chrome/grit/ios_strings.h"

@@ -44,19 +43,12 @@ TEST_F(ContentSettingsCollectionViewControllerTest, TestModel) {

CheckTitleWithId(IDS_IOS_CONTENT_SETTINGS_TITLE);

ASSERT_EQ(1, NumberOfSections());

- // Compose Email section is shown only if experiment is turned on.

- bool show_compose_email_section =

- !experimental_flags::IsNativeAppLauncherEnabled();

- int expectedNumberOfItems = show_compose_email_section ? 3 : 2;

- EXPECT_EQ(expectedNumberOfItems, NumberOfItemsInSection(0));

+ EXPECT_EQ(3, NumberOfItemsInSection(0));

CheckDetailItemTextWithIds(IDS_IOS_BLOCK_POPUPS, IDS_IOS_SETTING_ON, 0, 0);

CheckDetailItemTextWithIds(IDS_IOS_TRANSLATE_SETTING, IDS_IOS_SETTING_ON, 0,

1);

- if (show_compose_email_section) {

- CollectionViewDetailItem* item = GetCollectionViewItem(0, 2);

- EXPECT_NSEQ(l10n_util::GetNSString(IDS_IOS_COMPOSE_EMAIL_SETTING),

- item.text);

- }

+ CollectionViewDetailItem* item = GetCollectionViewItem(0, 2);

+ EXPECT_NSEQ(l10n_util::GetNSString(IDS_IOS_COMPOSE_EMAIL_SETTING), item.text);

}

} // namespace