Make histogram_suffixes separators and enum labels required.

Make histogram_suffixes separators and enum labels required.

It's somewhat common for metric authors to specify the wrong separator when
using a histogram_suffixes element, as the default is underscore, whereas dot is
common. This CL makes it harder to use the wrong separator by making the
attribute required.

Relatedly, this CL makes enum labels required (fixing one enum that lacked
labels), and makes name attributes always required.

BUG=724311
TEST=git cl format
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2894833005
Cr-Commit-Position: refs/heads/master@{#473425}
Committed: https://chromium.googlesource.com/chromium/src/+/1db4a0bab64a90b7b6f2999f571b725fa813ea35

[Ilya Sherman, 2017-05-19 22:03:55]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:04:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 22:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:07:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ilya Sherman, 2017-05-19 22:29:26]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:30:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-05-19 22:32:16]

I've split off the part of [ https://codereview.chromium.org/2890013004/ ] that
shouldn't require any server-side changes, and also is probably the most
impactful for folks editing the XML files.  PTAL!

[Alexei Svitkine (slow), 2017-05-19 22:38:28]

lgtm

[Ilya Sherman, 2017-05-19 22:47:16]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2017-05-19 22:47:17]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:47:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 03:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:08:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ilya Sherman, 2017-05-20 07:14:19]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-05-20 07:14:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 08:02:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495264459712580,
"parent_rev": "ad7db799a342aeb3a8f78ce04d5a09db71e3b03f", "commit_rev":
"1db4a0bab64a90b7b6f2999f571b725fa813ea35"}

[commit-bot: I haz the power, 2017-05-20 08:02:17]

Description was changed from

==========
Make histogram_suffixes separators and enum labels required.

It's somewhat common for metric authors to specify the wrong separator when
using a histogram_suffixes element, as the default is underscore, whereas dot is
common. This CL makes it harder to use the wrong separator by making the
attribute required.

Relatedly, this CL makes enum labels required (fixing one enum that lacked
labels), and makes name attributes always required.

BUG=724311
TEST=git cl format
R=asvitkine@chromium.org
==========

to

==========
Make histogram_suffixes separators and enum labels required.

It's somewhat common for metric authors to specify the wrong separator when
using a histogram_suffixes element, as the default is underscore, whereas dot is
common. This CL makes it harder to use the wrong separator by making the
attribute required.

Relatedly, this CL makes enum labels required (fixing one enum that lacked
labels), and makes name attributes always required.

BUG=724311
TEST=git cl format
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2894833005
Cr-Commit-Position: refs/heads/master@{#473425}
Committed:
https://chromium.googlesource.com/chromium/src/+/1db4a0bab64a90b7b6f2999f571b...
==========

[commit-bot: I haz the power, 2017-05-20 08:02:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1db4a0bab64a90b7b6f2999f571b...