Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tools/metrics/histograms/enums.xml

Issue 2894833005: Make histogram_suffixes separators and enum labels required. (Closed)
Patch Set: Rebase, and improve the error reporting logic Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « tools/metrics/common/pretty_print_xml.py ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/enums.xml
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index f09bdb34d9ca857edd35d8fc5f3cc69063b3716c..a5fbb271f7e929dc662b1f37dc1a4ce82306ef41 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -15995,15 +15995,14 @@ uploading your change for review. These are checked by presubmit scripts.
</enum>
<enum name="FtpDataConnectionError" type="int">
- <int value="0">Data connection successful</int>
- <int value="1">Local firewall blocked the connection</int>
- <int value="2">Connection timed out</int>
- <int value="3">
- Connection has been established, but then got broken (either reset or
- aborted)
- </int>
- <int value="4">Connection has been refused</int>
- <int value="20">Other kind of error</int>
+ <int value="0" label="Data connection successful"/>
+ <int value="1" label="Local firewall blocked the connection"/>
+ <int value="2" label="Connection timed out"/>
+ <int value="3"
+ label="Connection has been established, but then got broken (either
+ reset or aborted)"/>
+ <int value="4" label="Connection has been refused"/>
+ <int value="20" label="Other kind of error"/>
</enum>
<enum name="FtpServerType" type="int">
@@ -33431,9 +33430,7 @@ from previous Chrome versions.
<int value="11" label="SELF_SIGNED: The cert is self-signed">
This cause is recorded only for CERT_AUTHORITY_INVALID errors.
</int>
- <int value="12" label="EXPIRED_RECENTLY: Cert expired within last 28 days.">
-
- </int>
+ <int value="12" label="EXPIRED_RECENTLY: Cert expired within last 28 days."/>
<int value="13" label="LIKELY_SAME_DOMAIN: (Deprecated)">
(Deprecated in favor of LIKELY_SAME_DOMAIN2)
</int>
« no previous file with comments | « tools/metrics/common/pretty_print_xml.py ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698