[subresource_filter] Add observer interface for page activation

[subresource_filter] Add observer interface for page activation

Right now the throttle manager is the only consumer of the API, but in
a followup we will make the SubresourceFilterMetricsObserver.

BUG=717590
Review-Url: https://codereview.chromium.org/2894813003
Cr-Commit-Position: refs/heads/master@{#474071}
Committed: https://chromium.googlesource.com/chromium/src/+/c47dcd1fde8e0434cd6094974ed51d54a88a44a9

[Charlie Harrison, 2017-05-19 15:12:57]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 15:13:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 15:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 15:16:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Charlie Harrison, 2017-05-19 15:23:23]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 15:23:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-19 15:39:21]

csharrison@chromium.org changed reviewers:
+ bmcquade@chromium.org

[Charlie Harrison, 2017-05-19 15:39:22]

Bryan: this was my idea to set up an observer interface, WDYT? It doesn't hook
up to the metrics throttle yet.

[commit-bot: I haz the power, 2017-05-19 16:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:51:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2017-05-22 18:48:49]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:49:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-22 19:18:24]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:18:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-22 19:19:09]

Ok I've thought about it and decided to use a method
OnSubresourceFilterGoingAway to prevent use-after-free and implicit WCO ordering
issues.

[commit-bot: I haz the power, 2017-05-22 21:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 21:03:16]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-05-23 19:28:27]

lgtm

[Charlie Harrison, 2017-05-23 19:48:19]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:48:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:45:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495568899851830,
"parent_rev": "e1cdc972614971510f7de2672de8f782fd07385e", "commit_rev":
"ad37c3c5f59d3585afaba719dad0beabf54d9a3b"}

[commit-bot: I haz the power, 2017-05-23 21:45:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495568899851830,
"parent_rev": "63646a2e27a81a5688a296f99ddff46493476034", "commit_rev":
"c47dcd1fde8e0434cd6094974ed51d54a88a44a9"}

[commit-bot: I haz the power, 2017-05-23 21:45:51]

Description was changed from

==========
[subresource_filter] Add observer interface for page activation

Right now the throttle manager is the only consumer of the API, but in
a followup we will make the SubresourceFilterMetricsObserver.

BUG=717590
==========

to

==========
[subresource_filter] Add observer interface for page activation

Right now the throttle manager is the only consumer of the API, but in
a followup we will make the SubresourceFilterMetricsObserver.

BUG=717590

Review-Url: https://codereview.chromium.org/2894813003
Cr-Commit-Position: refs/heads/master@{#474071}
Committed:
https://chromium.googlesource.com/chromium/src/+/c47dcd1fde8e0434cd6094974ed5...
==========

[commit-bot: I haz the power, 2017-05-23 21:45:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c47dcd1fde8e0434cd6094974ed5...