Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9344)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2894813003: [subresource_filter] Add observer interface for page activation (Closed)
Patch Set: use another method Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
index 09b402af04159c2f2e9be958f15546f6b2f93b59..ebed18f52b6289869060ec0b50fe3e5d2072e1da 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
@@ -11,6 +11,7 @@
#include "base/trace_event/trace_event_argument.h"
#include "components/subresource_filter/content/browser/content_activation_list_utils.h"
#include "components/subresource_filter/content/browser/subresource_filter_client.h"
+#include "components/subresource_filter/content/browser/subresource_filter_observer_manager.h"
#include "components/subresource_filter/core/browser/subresource_filter_features.h"
#include "components/subresource_filter/core/common/activation_list.h"
#include "components/subresource_filter/core/common/activation_state.h"
@@ -122,7 +123,9 @@ void ContentSubresourceFilterDriverFactory::OnSafeBrowsingMatchComputed(
// TODO(csharrison): Set state.enable_logging based on metadata returns from
// the safe browsing filter, when it is available. Add tests for this
// behavior.
- throttle_manager_->NotifyPageActivationComputed(navigation_handle, state);
+ SubresourceFilterObserverManager::FromWebContents(web_contents())
+ ->NotifyPageActivationComputed(navigation_handle, activation_decision_,
+ state);
}
// Be careful when modifying this method, as the order in which the

Powered by Google App Engine
This is Rietveld 408576698