Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2894693002: Add UseCounter to measure edits to text fields by security state (Closed)

Created:
6 months ago by elawrence
Modified:
6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter to measure edits to text fields by security state To evaluate the impact and effectiveness of HTTPBad Phase 2's form field warnings, we need to record how many page loads result in the user entering data in a text field on the page, split by whether or not the form field's context is secure. BUG=724260 NOTRY=true Review-Url: https://codereview.chromium.org/2894693002 Cr-Commit-Position: refs/heads/master@{#473294} Committed: https://chromium.googlesource.com/chromium/src/+/f7f0f1c1aae1bfc819afddb0024d14af0d3c8ff4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
elawrence
PTAL?
6 months ago (2017-05-18 21:47:46 UTC) #2
dcheng
LGTM
6 months ago (2017-05-19 13:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894693002/1
6 months ago (2017-05-19 13:51:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/214857) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
6 months ago (2017-05-19 13:53:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894693002/20001
6 months ago (2017-05-19 14:32:38 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
6 months ago (2017-05-19 16:34:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894693002/40001
6 months ago (2017-05-19 17:31:23 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
6 months ago (2017-05-19 19:50:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894693002/60001
6 months ago (2017-05-19 20:13:22 UTC) #21
commit-bot: I haz the power
6 months ago (2017-05-19 20:22:18 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f7f0f1c1aae1bfc819afddb0024d...

Powered by Google App Engine
This is Rietveld efc10ee0f