Add UseCounter to measure edits to text fields by security state

Add UseCounter to measure edits to text fields by security state

To evaluate the impact and effectiveness of HTTPBad Phase 2's
form field warnings, we need to record how many page loads result
in the user entering data in a text field on the page, split by
whether or not the form field's context is secure.

BUG=724260
NOTRY=true

Review-Url: https://codereview.chromium.org/2894693002
Cr-Commit-Position: refs/heads/master@{#473294}
Committed: https://chromium.googlesource.com/chromium/src/+/f7f0f1c1aae1bfc819afddb0024d14af0d3c8ff4

[elawrence, 2017-05-18 21:47:46]

elawrence@chromium.org changed reviewers:
+ dcheng@chromium.org

[elawrence, 2017-05-18 21:47:46]

PTAL?

[dcheng, 2017-05-19 13:48:22]

LGTM

[elawrence, 2017-05-19 13:51:11]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:51:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 13:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:53:19]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[elawrence, 2017-05-19 14:32:03]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-19 14:32:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2894693002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-19 14:32:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:34:45]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1585
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
  U third_party/WebKit/Source/core/frame/UseCounter.h

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
f6209bfbf07310e33332a7888b0df623891f4463..51e59f311d7ef050d89c2478da1e49eb42877629
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1585,6 +1585,8 @@ class CORE_EXPORT UseCounter {
     kPaymentRequestNetworkNameInSupportedMethods = 1976,
     kCrossOriginPropertyAccess = 1977,
     kCrossOriginPropertyAccessFromOpener = 1978,
+    kFieldEditInSecureContext = 1979,
+    kFieldEditInNonSecureContext = 1980,
 
     // Add new features immediately above this line. Don't change assigned
     // numbers of any item, and don't reuse removed slots.

[elawrence, 2017-05-19 17:30:52]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-19 17:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2894693002/#ps40001
(title: "git cl web")

[commit-bot: I haz the power, 2017-05-19 17:31:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:50:36]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1586
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
  U third_party/WebKit/Source/core/frame/UseCounter.h

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
44f4d419c8855fe0e44743933a42d838c5d3dad5..a9e5942184701b84e7d9063ecd2a62b16573e988
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1586,6 +1586,8 @@ class CORE_EXPORT UseCounter {
     kCrossOriginPropertyAccess = 1977,
     kCrossOriginPropertyAccessFromOpener = 1978,
     kCredentialManagerCreate = 1979,
+    kFieldEditInSecureContext = 1980,
+    kFieldEditInNonSecureContext = 1981,
 
     // Add new features immediately above this line. Don't change assigned
     // numbers of any item, and don't reuse removed slots.

[elawrence, 2017-05-19 20:11:03]

Description was changed from

==========
Add UseCounter to measure edits to text fields by security state

To evaluate the impact and effectiveness of HTTPBad Phase 2's
form field warnings, we need to record how many page loads result
in the user entering data in a text field on the page, split by
whether or not the form field's context is secure.

BUG=724260
==========

to

==========
Add UseCounter to measure edits to text fields by security state

To evaluate the impact and effectiveness of HTTPBad Phase 2's
form field warnings, we need to record how many page loads result
in the user entering data in a text field on the page, split by
whether or not the form field's context is secure.

BUG=724260

NOTRY=true
==========

[elawrence, 2017-05-19 20:12:21]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-19 20:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2894693002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-19 20:13:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:22:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495224741474620,
"parent_rev": "082f0e6aa47050a15c1d2adef8966cad11298f76", "commit_rev":
"f7f0f1c1aae1bfc819afddb0024d14af0d3c8ff4"}

[commit-bot: I haz the power, 2017-05-19 20:22:16]

Description was changed from

==========
Add UseCounter to measure edits to text fields by security state

To evaluate the impact and effectiveness of HTTPBad Phase 2's
form field warnings, we need to record how many page loads result
in the user entering data in a text field on the page, split by
whether or not the form field's context is secure.

BUG=724260

NOTRY=true
==========

to

==========
Add UseCounter to measure edits to text fields by security state

To evaluate the impact and effectiveness of HTTPBad Phase 2's
form field warnings, we need to record how many page loads result
in the user entering data in a text field on the page, split by
whether or not the form field's context is secure.

BUG=724260

NOTRY=true

Review-Url: https://codereview.chromium.org/2894693002
Cr-Commit-Position: refs/heads/master@{#473294}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7f0f1c1aae1bfc819afddb0024d...
==========

[commit-bot: I haz the power, 2017-05-19 20:22:18]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f7f0f1c1aae1bfc819afddb0024d...