Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2894683003: Revert of Re-enable GPU watchdog for WebGL conformance tests. (Closed)

Created:
3 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, vmiura
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable GPU watchdog for WebGL conformance tests. (patchset #1 id:1 of https://codereview.chromium.org/2887983002/ ) Reason for revert: Unfortunately the GPU watchdog is still flakily firing, destabilizing these tests. See: https://bugs.chromium.org/p/chromium/issues/detail?id=609252#c75 Original issue's description: > Re-enable GPU watchdog for WebGL conformance tests. > > See whether this is working any more reliably now. > > BUG=609252 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2887983002 > Cr-Commit-Position: refs/heads/master@{#472378} > Committed: https://chromium.googlesource.com/chromium/src/+/8f97866e8f0c1bae205fe0f3a4107d41ba8bae28 TBR=zmo@chromium.org # Manually skipping Windows CQ tryservers because of unrelated failures. NOTRY=true BUG=609252 Review-Url: https://codereview.chromium.org/2894683003 Cr-Commit-Position: refs/heads/master@{#473009} Committed: https://chromium.googlesource.com/chromium/src/+/f69a6aae1e44f2a8d5acee4979eb109b4884b9ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Russell (switch to Gerrit)
Created Revert of Re-enable GPU watchdog for WebGL conformance tests.
3 years, 7 months ago (2017-05-18 21:39:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894683003/1
3 years, 7 months ago (2017-05-18 21:41:41 UTC) #3
Ken Russell (switch to Gerrit)
I'm landing this NOTRY=true. The Windows failures are unrelated and having this turned on is ...
3 years, 7 months ago (2017-05-19 01:04:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894683003/1
3 years, 7 months ago (2017-05-19 01:06:22 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:14:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f69a6aae1e44f2a8d5acee4979eb...

Powered by Google App Engine
This is Rietveld 408576698