Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887983002:
Re-enable GPU watchdog for WebGL conformance tests. (Closed)
|
Created:
3 years, 7 months ago by Ken Russell (switch to Gerrit) Modified:
3 years, 7 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, vmiura Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable GPU watchdog for WebGL conformance tests.
See whether this is working any more reliably now.
BUG=609252
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2887983002
Cr-Commit-Position: refs/heads/master@{#472378}
Committed: https://chromium.googlesource.com/chromium/src/+/8f97866e8f0c1bae205fe0f3a4107d41ba8bae28
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Re-enable GPU watchdog for WebGL conformance tests. See whether this is working any more reliably now. BUG=609252 ========== to ========== Re-enable GPU watchdog for WebGL conformance tests. See whether this is working any more reliably now. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
PTAL
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495004342913810, "parent_rev":
"3a4093c16bb741a0b3acd5f2b124f0b5a03880f7", "commit_rev":
"8f97866e8f0c1bae205fe0f3a4107d41ba8bae28"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable GPU watchdog for WebGL conformance tests. See whether this is working any more reliably now. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Re-enable GPU watchdog for WebGL conformance tests. See whether this is working any more reliably now. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2887983002 Cr-Commit-Position: refs/heads/master@{#472378} Committed: https://chromium.googlesource.com/chromium/src/+/8f97866e8f0c1bae205fe0f3a410... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8f97866e8f0c1bae205fe0f3a410...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2894683003/ by kbr@chromium.org. The reason for reverting is: Unfortunately the GPU watchdog is still flakily firing, destabilizing these tests. See: https://bugs.chromium.org/p/chromium/issues/detail?id=609252#c75 . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
