|
|
DescriptionEnable chrome devtools server to be accessible by DevTool clients within
internal network.
Currently Devtool uses localhost as the default IP so accessing Devtool
server from a different machine within the same network doesn't work.
BUG=724276
Review-Url: https://codereview.chromium.org/2894673005
Cr-Commit-Position: refs/heads/master@{#474554}
Committed: https://chromium.googlesource.com/chromium/src/+/ee2e26b4a2399340086d0295e9bb6d8eee6a9507
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 23 (18 generated)
Description was changed from ========== Enable chrome devtools server to be accessible by DevTool clients within internal network. BUG=724276 ========== to ========== Enable chrome devtools server to be accessible by DevTool clients within internal network. Currently Devtool uses localhost as the default IP so accessing Devtool server from a different machine within the same network doesn't work. BUG=724276 ==========
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thanhph@chromium.org changed reviewers: + sadrul@chromium.org
Hi Sadrul, Please review my patch. Thanks, Thanh.
sadrul@chromium.org changed reviewers: + dgozman@chromium.org
+dgozman@ Looks reasonable to me, but I don't know if there are better ways of doing this. +dgozman@ for review.
lgtm
The CQ bit was checked by thanhph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495670980245630, "parent_rev": "e405cee7a4b8722f838cc41c38058318a1a71ae6", "commit_rev": "ee2e26b4a2399340086d0295e9bb6d8eee6a9507"}
Message was sent while issue was closed.
Description was changed from ========== Enable chrome devtools server to be accessible by DevTool clients within internal network. Currently Devtool uses localhost as the default IP so accessing Devtool server from a different machine within the same network doesn't work. BUG=724276 ========== to ========== Enable chrome devtools server to be accessible by DevTool clients within internal network. Currently Devtool uses localhost as the default IP so accessing Devtool server from a different machine within the same network doesn't work. BUG=724276 Review-Url: https://codereview.chromium.org/2894673005 Cr-Commit-Position: refs/heads/master@{#474554} Committed: https://chromium.googlesource.com/chromium/src/+/ee2e26b4a2399340086d0295e9bb... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ee2e26b4a2399340086d0295e9bb... |