Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: components/ui_devtools/devtools_server.cc

Issue 2894673005: Enable chrome devtools server to be accessible by DevTool clients within internal network. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/devtools_server.cc
diff --git a/components/ui_devtools/devtools_server.cc b/components/ui_devtools/devtools_server.cc
index 5ed5794518990c340edd401e3bace86eb58a4b7c..a57c9ab3eb09167df5fcb2eba84c88aeb25b93bd 100644
--- a/components/ui_devtools/devtools_server.cc
+++ b/components/ui_devtools/devtools_server.cc
@@ -74,7 +74,7 @@ std::unique_ptr<UiDevToolsServer> UiDevToolsServer::Create(
if (IsUiDevToolsEnabled() && !devtools_server_) {
// TODO(mhashmi): Change port if more than one inspectable clients
server.reset(new UiDevToolsServer(io_thread_task_runner));
- server->Start("127.0.0.1", GetUiDevToolsPort());
+ server->Start("0.0.0.0", GetUiDevToolsPort());
}
return server;
}
@@ -90,9 +90,8 @@ UiDevToolsServer::GetClientNamesAndUrls() {
i++) {
pairs.push_back(std::pair<std::string, std::string>(
devtools_server_->clients_[i]->name(),
- base::StringPrintf("%slocalhost:%d/%" PRIuS,
- kChromeDeveloperToolsPrefix, GetUiDevToolsPort(),
- i)));
+ base::StringPrintf("%s0.0.0.0:%d/%" PRIuS, kChromeDeveloperToolsPrefix,
+ GetUiDevToolsPort(), i)));
}
return pairs;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698