Add |web_usage_enabled| to DeserializeWebStateList()

Add |web_usage_enabled| to DeserializeWebStateList()

This allows the TabModel to pass its |webUsageEnabled_| value to the
deserialized WebStateList, which prevents hitting a CHECK() in
CRWWebController for attempting to trigger a load for a WebState with
disabled web usage.

BUG=723665
TEST=Open Chrome, navigate to a page, quit debugger, then start up the
app again and restore tabs.  Should not crash.

Review-Url: https://codereview.chromium.org/2894553003
Cr-Commit-Position: refs/heads/master@{#473249}
Committed: https://chromium.googlesource.com/chromium/src/+/59b25f6c12708adf7dbce3a4e08eb15ab845626b

[kkhorimoto, 2017-05-18 21:46:15]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-05-18 21:46:16]

https://codereview.chromium.org/2894553003/diff/20001/ios/shared/chrome/brows...
File
ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm
(right):

https://codereview.chromium.org/2894553003/diff/20001/ios/shared/chrome/brows...
ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm:237:
DeserializeWebStateList(&web_state_list, session_window, false,
I've used false here to maintain previous behavior, but we should look into
whether we want to track web usage on a browser list level

[Eugene But (OOO till 7-30), 2017-05-18 23:37:18]

https://codereview.chromium.org/2894553003/diff/20001/ios/chrome/browser/web_...
File ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
(right):

https://codereview.chromium.org/2894553003/diff/20001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:132:
&restored_web_state_list, session_window, false,
Can we test that true/false actually make a difference?

[kkhorimoto, 2017-05-19 00:25:29]

https://codereview.chromium.org/2894553003/diff/20001/ios/chrome/browser/web_...
File ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
(right):

https://codereview.chromium.org/2894553003/diff/20001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:132:
&restored_web_state_list, session_window, false,
On 2017/05/18 23:37:18, Eugene But wrote:
> Can we test that true/false actually make a difference?

Done.

[Eugene But (OOO till 7-30), 2017-05-19 14:18:05]

Thanks for the tests. lgtm!

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
File ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
(right):

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:162:
// WebStateLists.
ASSERT_EQ(restored_web_state_list_web_usage_enabled.count(),
restored_web_state_list.count()) ?

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:163:
for (int i = 0; i < 5; ++i) {
s/5/restored_web_state_list_web_usage_enabled.count() ?

[kkhorimoto, 2017-05-19 17:58:16]

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
File ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
(right):

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:162:
// WebStateLists.
On 2017/05/19 14:18:05, Eugene But wrote:
> ASSERT_EQ(restored_web_state_list_web_usage_enabled.count(),
> restored_web_state_list.count()) ?

Done.

https://codereview.chromium.org/2894553003/diff/40001/ios/chrome/browser/web_...
ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm:163:
for (int i = 0; i < 5; ++i) {
On 2017/05/19 14:18:05, Eugene But wrote:
> s/5/restored_web_state_list_web_usage_enabled.count() ?

Done.

[kkhorimoto, 2017-05-19 17:58:21]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-05-19 17:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2894553003/#ps60001
(title: "Eugene's comments")

[commit-bot: I haz the power, 2017-05-19 17:58:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 18:13:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495216701858330,
"parent_rev": "ace23bbd22c0bf5523755fb7d611d6a144a8dab0", "commit_rev":
"59b25f6c12708adf7dbce3a4e08eb15ab845626b"}

[commit-bot: I haz the power, 2017-05-19 18:14:10]

Description was changed from

==========
Add |web_usage_enabled| to DeserializeWebStateList()

This allows the TabModel to pass its |webUsageEnabled_| value to the
deserialized WebStateList, which prevents hitting a CHECK() in
CRWWebController for attempting to trigger a load for a WebState with
disabled web usage.

BUG=723665
TEST=Open Chrome, navigate to a page, quit debugger, then start up the
app again and restore tabs.  Should not crash.
==========

to

==========
Add |web_usage_enabled| to DeserializeWebStateList()

This allows the TabModel to pass its |webUsageEnabled_| value to the
deserialized WebStateList, which prevents hitting a CHECK() in
CRWWebController for attempting to trigger a load for a WebState with
disabled web usage.

BUG=723665
TEST=Open Chrome, navigate to a page, quit debugger, then start up the
app again and restore tabs.  Should not crash.

Review-Url: https://codereview.chromium.org/2894553003
Cr-Commit-Position: refs/heads/master@{#473249}
Committed:
https://chromium.googlesource.com/chromium/src/+/59b25f6c12708adf7dbce3a4e08e...
==========

[commit-bot: I haz the power, 2017-05-19 18:14:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/59b25f6c12708adf7dbce3a4e08e...